Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] PCI: dwc: pci-dra7xx: Add missing include file
@ 2019-06-14 15:40 YueHaibing
  2019-07-05 15:29 ` Lorenzo Pieralisi
  2019-07-09 16:45 ` Lorenzo Pieralisi
  0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2019-06-14 15:40 UTC (permalink / raw)
  To: kishon, lorenzo.pieralisi, bhelgaas
  Cc: linux-kernel, linux-pci, linux-omap, YueHaibing

Fix build error:

drivers/pci/controller/dwc/pci-dra7xx.c:
 In function dra7xx_pcie_probe:
drivers/pci/controller/dwc/pci-dra7xx.c:777:10:
 error: implicit declaration of function devm_gpiod_get_optional;
 did you mean devm_regulator_get_optional? [-Werror=implicit-function-declaration]

  reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH);

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/pci/controller/dwc/pci-dra7xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
index 419451e..4234ddb 100644
--- a/drivers/pci/controller/dwc/pci-dra7xx.c
+++ b/drivers/pci/controller/dwc/pci-dra7xx.c
@@ -26,6 +26,7 @@
 #include <linux/types.h>
 #include <linux/mfd/syscon.h>
 #include <linux/regmap.h>
+#include <linux/gpio/consumer.h>
 
 #include "../../pci.h"
 #include "pcie-designware.h"
-- 
2.7.4



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: dwc: pci-dra7xx: Add missing include file
  2019-06-14 15:40 [PATCH] PCI: dwc: pci-dra7xx: Add missing include file YueHaibing
@ 2019-07-05 15:29 ` Lorenzo Pieralisi
  2019-07-09 11:22   ` Kishon Vijay Abraham I
  2019-07-09 16:45 ` Lorenzo Pieralisi
  1 sibling, 1 reply; 4+ messages in thread
From: Lorenzo Pieralisi @ 2019-07-05 15:29 UTC (permalink / raw)
  To: YueHaibing, kishon; +Cc: bhelgaas, linux-kernel, linux-pci, linux-omap

On Fri, Jun 14, 2019 at 11:40:44PM +0800, YueHaibing wrote:
> Fix build error:
> 
> drivers/pci/controller/dwc/pci-dra7xx.c:
>  In function dra7xx_pcie_probe:
> drivers/pci/controller/dwc/pci-dra7xx.c:777:10:
>  error: implicit declaration of function devm_gpiod_get_optional;
>  did you mean devm_regulator_get_optional? [-Werror=implicit-function-declaration]
> 
>   reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH);

Adding the reason (in particular the config options) that triggers
this error would not hurt.

Kishon please let me know if I can merge it (ACK it if so).

Thanks,
Lorenzo

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/pci/controller/dwc/pci-dra7xx.c | 1 +
>  1 file changed, 1 insertion(+)


> 
> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
> index 419451e..4234ddb 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -26,6 +26,7 @@
>  #include <linux/types.h>
>  #include <linux/mfd/syscon.h>
>  #include <linux/regmap.h>
> +#include <linux/gpio/consumer.h>
>  
>  #include "../../pci.h"
>  #include "pcie-designware.h"
> -- 
> 2.7.4
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: dwc: pci-dra7xx: Add missing include file
  2019-07-05 15:29 ` Lorenzo Pieralisi
@ 2019-07-09 11:22   ` Kishon Vijay Abraham I
  0 siblings, 0 replies; 4+ messages in thread
From: Kishon Vijay Abraham I @ 2019-07-09 11:22 UTC (permalink / raw)
  To: Lorenzo Pieralisi, YueHaibing
  Cc: bhelgaas, linux-kernel, linux-pci, linux-omap



On 05/07/19 8:59 PM, Lorenzo Pieralisi wrote:
> On Fri, Jun 14, 2019 at 11:40:44PM +0800, YueHaibing wrote:
>> Fix build error:
>>
>> drivers/pci/controller/dwc/pci-dra7xx.c:
>>  In function dra7xx_pcie_probe:
>> drivers/pci/controller/dwc/pci-dra7xx.c:777:10:
>>  error: implicit declaration of function devm_gpiod_get_optional;
>>  did you mean devm_regulator_get_optional? [-Werror=implicit-function-declaration]
>>
>>   reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH);
> 
> Adding the reason (in particular the config options) that triggers
> this error would not hurt.
> 
> Kishon please let me know if I can merge it (ACK it if so).

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> 
> Thanks,
> Lorenzo
> 
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  drivers/pci/controller/dwc/pci-dra7xx.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> 
>>
>> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
>> index 419451e..4234ddb 100644
>> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
>> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
>> @@ -26,6 +26,7 @@
>>  #include <linux/types.h>
>>  #include <linux/mfd/syscon.h>
>>  #include <linux/regmap.h>
>> +#include <linux/gpio/consumer.h>
>>  
>>  #include "../../pci.h"
>>  #include "pcie-designware.h"
>> -- 
>> 2.7.4
>>
>>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: dwc: pci-dra7xx: Add missing include file
  2019-06-14 15:40 [PATCH] PCI: dwc: pci-dra7xx: Add missing include file YueHaibing
  2019-07-05 15:29 ` Lorenzo Pieralisi
@ 2019-07-09 16:45 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2019-07-09 16:45 UTC (permalink / raw)
  To: YueHaibing; +Cc: kishon, bhelgaas, linux-kernel, linux-pci, linux-omap

On Fri, Jun 14, 2019 at 11:40:44PM +0800, YueHaibing wrote:
> Fix build error:
> 
> drivers/pci/controller/dwc/pci-dra7xx.c:
>  In function dra7xx_pcie_probe:
> drivers/pci/controller/dwc/pci-dra7xx.c:777:10:
>  error: implicit declaration of function devm_gpiod_get_optional;
>  did you mean devm_regulator_get_optional? [-Werror=implicit-function-declaration]
> 
>   reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH);
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/pci/controller/dwc/pci-dra7xx.c | 1 +
>  1 file changed, 1 insertion(+)

Applied to pci/dwc for v5.3, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
> index 419451e..4234ddb 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -26,6 +26,7 @@
>  #include <linux/types.h>
>  #include <linux/mfd/syscon.h>
>  #include <linux/regmap.h>
> +#include <linux/gpio/consumer.h>
>  
>  #include "../../pci.h"
>  #include "pcie-designware.h"
> -- 
> 2.7.4
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 15:40 [PATCH] PCI: dwc: pci-dra7xx: Add missing include file YueHaibing
2019-07-05 15:29 ` Lorenzo Pieralisi
2019-07-09 11:22   ` Kishon Vijay Abraham I
2019-07-09 16:45 ` Lorenzo Pieralisi

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org linux-pci@archiver.kernel.org
	public-inbox-index linux-pci


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox