From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2294C31E57 for ; Mon, 17 Jun 2019 09:33:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3B8E2085A for ; Mon, 17 Jun 2019 09:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726005AbfFQJdm (ORCPT ); Mon, 17 Jun 2019 05:33:42 -0400 Received: from foss.arm.com ([217.140.110.172]:43130 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbfFQJdm (ORCPT ); Mon, 17 Jun 2019 05:33:42 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A35D8344; Mon, 17 Jun 2019 02:33:41 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9CA903F246; Mon, 17 Jun 2019 02:33:39 -0700 (PDT) Date: Mon, 17 Jun 2019 10:33:37 +0100 From: Lorenzo Pieralisi To: "Z.q. Hou" Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "l.subrahmanya@mobiveil.co.in" , "shawnguo@kernel.org" , Leo Li , "catalin.marinas@arm.com" , "will.deacon@arm.com" , Mingkai Hu , "M.h. Lian" , Xiaowei Bao Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag MSI_FLAG_MULTI_PCI_MSI Message-ID: <20190617093337.GD18020@e121166-lin.cambridge.arm.com> References: <20190412083635.33626-1-Zhiqiang.Hou@nxp.com> <20190412083635.33626-5-Zhiqiang.Hou@nxp.com> <20190611165935.GA22836@redmoon> <20190612130813.GA15747@redmoon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat, Jun 15, 2019 at 01:30:39AM +0000, Z.q. Hou wrote: > Hi Lorenzo, > > > -----Original Message----- > > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com] > > Sent: 2019年6月12日 21:08 > > To: Z.q. Hou > > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com; > > l.subrahmanya@mobiveil.co.in; shawnguo@kernel.org; Leo Li > > ; catalin.marinas@arm.com; will.deacon@arm.com; > > Mingkai Hu ; M.h. Lian ; > > Xiaowei Bao > > Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag > > MSI_FLAG_MULTI_PCI_MSI > > > > On Wed, Jun 12, 2019 at 11:34:51AM +0000, Z.q. Hou wrote: > > > Hi Lorenzo, > > > > > > Thanks a lot for your comments! > > > > > > > -----Original Message----- > > > > From: Lorenzo Pieralisi > > > > Sent: 2019年6月12日 1:00 > > > > To: Z.q. Hou > > > > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com; > > > > l.subrahmanya@mobiveil.co.in; shawnguo@kernel.org; Leo Li > > > > ; catalin.marinas@arm.com; > > will.deacon@arm.com; > > > > Mingkai Hu ; M.h. Lian > > ; > > > > Xiaowei Bao > > > > Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag > > > > MSI_FLAG_MULTI_PCI_MSI > > > > > > > > On Fri, Apr 12, 2019 at 08:35:36AM +0000, Z.q. Hou wrote: > > > > > From: Hou Zhiqiang > > > > > > > > > > The current code does not support multiple MSIs, so remove the > > > > > corresponding flag from the msi_domain_info structure. > > > > > > > > Please explain me what's the problem before removing multi MSI support. > > > > > > NXP LX2 PCIe use the GIC-ITS instead of Mobiveil IP internal MSI > > > controller, so, I didn't encounter problem. > > > > Well, you sent a patch to fix an issue, explain me the issue you are fixing then, > > aka what have you sent this patch for ? > > I did not face issue, as I have explained NXP does not use the > Mobiveil IP's MSI controller. But obviously the MSI allocate function > does not support multiple MSI, so I submitted this patch. There is nothing obvious. Write what you are fixing in the commit log and I will apply the patch, I won't write the commit log for you. Anyone should be able to understand why a patch was needed by reading the commit log, it is as important as writing the code itself. Thanks, Lorenzo > Thanks, > Zhiqiang > > > > > Lorenzo > > > > > Subbu, did you test with Endpoint supporting multi MSI? > > > > > > Thanks, > > > Zhiqiang > > > > > > > > > > > Thanks, > > > > Lorenzo > > > > > > > > > Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support") > > > > > Signed-off-by: Hou Zhiqiang > > > > > Reviewed-by: Minghuan Lian > > > > > --- > > > > > V5: > > > > > - Corrected the subject. > > > > > > > > > > drivers/pci/controller/pcie-mobiveil.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/pci/controller/pcie-mobiveil.c > > > > > b/drivers/pci/controller/pcie-mobiveil.c > > > > > index 563210e731d3..a0dd337c6214 100644 > > > > > --- a/drivers/pci/controller/pcie-mobiveil.c > > > > > +++ b/drivers/pci/controller/pcie-mobiveil.c > > > > > @@ -703,7 +703,7 @@ static struct irq_chip mobiveil_msi_irq_chip = > > > > > { > > > > > > > > > > static struct msi_domain_info mobiveil_msi_domain_info = { > > > > > .flags = (MSI_FLAG_USE_DEF_DOM_OPS | > > > > MSI_FLAG_USE_DEF_CHIP_OPS | > > > > > - MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX), > > > > > + MSI_FLAG_PCI_MSIX), > > > > > .chip = &mobiveil_msi_irq_chip, > > > > > }; > > > > > > > > > > -- > > > > > 2.17.1 > > > > >