From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DB7C31E57 for ; Mon, 17 Jun 2019 11:48:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15CF520861 for ; Mon, 17 Jun 2019 11:48:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RGGbjb6x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725810AbfFQLsx (ORCPT ); Mon, 17 Jun 2019 07:48:53 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39016 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbfFQLsx (ORCPT ); Mon, 17 Jun 2019 07:48:53 -0400 Received: by mail-wr1-f65.google.com with SMTP id x4so9603509wrt.6; Mon, 17 Jun 2019 04:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YFZzGQiR/+q8BqcMsjHSVIUX4cRDO+kiz9QvlDUt+/o=; b=RGGbjb6x8Bl+gCJ6qmzaAQAjg3dzjOzIBHOEEY/T1qsZYPuqTqCYn/LK0QhJFDSJ1Z 5dCwlEjJP6C28OhXXYfENT7YKEZ85lf5ItpbENW1yYTOQfP5vA1O/AlTNQSnhvxqnpr2 5Xf5jw7QxELcjjmWM/1AgkVvH3Nquxy9JKNIhtoqvVC9npCFtjBNBh128Vsxrjdkziju 2FogeYr2uyOcOI22hWwg/oxPozky3R906gMcE9fVICrMtUca9Bt7d0RqFISwMdfy82u4 HNrBB8dn52aGgxF3bKhGk6TWkyJ9+xInu+J7x1W7e3f7N0BBifNbtaoor+o3Dw0na1oK VfRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YFZzGQiR/+q8BqcMsjHSVIUX4cRDO+kiz9QvlDUt+/o=; b=UfkKTgHJ4Qa+iYSwg80IY0HBHw7OF85qE+HwnXFnBHOtR5Ojzd7yVpJtydin0g9F2W NtEe0+LM26ScDoSG3WkFhwh1UZHNwpwCL+AeSghCReAHRZMF4h6/xjHh3WLEwFfYfknw Un7pdDAj7wdFJmSicfUAWYb4UNrmtu6FBvoUSwTnW/Kwl/90OJINo8bzZvId7lcqLyzL Z0sTp0N9edhOsRHepVS/CQHd+QPdN8I72cV7yurd1OjSK+vAlhN9svNK7D2b/P9ZdbuV 6xi9fOErqpsaEc05iPQL5rM19svJsqClo2PyG8z4UQWds46qYO9eJbuDNlxZJZeouQz6 yAtQ== X-Gm-Message-State: APjAAAXpXfdgpO5yAWuNgd0+uxNuRaHhjjC2GqZgz9hVbniAvCiBo4Pj moBeGlupYDAiWMcAUk9jmro= X-Google-Smtp-Source: APXvYqzbohfQXHTSgJpr150hQG2s0BU+/GxYSWrhYfr7eLtWqRK5RzlsTV/R1nmSt+iSooHPz6e06g== X-Received: by 2002:adf:dd82:: with SMTP id x2mr1576838wrl.27.1560772130643; Mon, 17 Jun 2019 04:48:50 -0700 (PDT) Received: from localhost (p2E5BEF36.dip0.t-ipconnect.de. [46.91.239.54]) by smtp.gmail.com with ESMTPSA id 18sm9533971wmg.43.2019.06.17.04.48.49 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 17 Jun 2019 04:48:49 -0700 (PDT) Date: Mon, 17 Jun 2019 13:48:49 +0200 From: Thierry Reding To: Manikanta Maddireddy Cc: bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, jonathanh@nvidia.com, lorenzo.pieralisi@arm.com, vidyas@nvidia.com, linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH V4 26/28] PCI: Add DT binding for "reset-gpios" property Message-ID: <20190617114849.GM508@ulmo> References: <20190516055307.25737-1-mmaddireddy@nvidia.com> <20190516055307.25737-27-mmaddireddy@nvidia.com> <20190617113038.GK508@ulmo> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TxukmIqg3MmZ0Kmh" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org --TxukmIqg3MmZ0Kmh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 17, 2019 at 05:08:45PM +0530, Manikanta Maddireddy wrote: >=20 >=20 > On 17-Jun-19 5:00 PM, Thierry Reding wrote: > > On Thu, May 16, 2019 at 11:23:05AM +0530, Manikanta Maddireddy wrote: > >> Add DT binding for "reset-gpios" property which supports GPIO based PE= RST# > >> signal. > >> > >> Signed-off-by: Manikanta Maddireddy > >> Reviewed-by: Rob Herring > >> Acked-by: Thierry Reding > >> --- > >> V4: No change > >> > >> V3: Moved to common pci binding doc > >> > >> V2: Using standard "reset-gpio" property > >> > >> Documentation/devicetree/bindings/pci/pci.txt | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documenta= tion/devicetree/bindings/pci/pci.txt > >> index c77981c5dd18..79124898aa5b 100644 > >> --- a/Documentation/devicetree/bindings/pci/pci.txt > >> +++ b/Documentation/devicetree/bindings/pci/pci.txt > >> @@ -24,3 +24,6 @@ driver implementation may support the following prop= erties: > >> unsupported link speed, for instance, trying to do training for > >> unsupported link speed, etc. Must be '4' for gen4, '3' for gen3, = '2' > >> for gen2, and '1' for gen1. Any other values are invalid. > >> +- reset-gpios: > >> + If present this property specifies PERST# GPIO. Host drivers can p= arse the > >> + GPIO and apply fundamental reset to endpoints. > > As mentioned in patch 27/28, maybe mention here that this is only a > > workaround for bad board designs and that it shouldn't be necessary in > > the majority of cases. > > > > Thierry >=20 > This is common DT binding doc, I cannot add Tegra specific here. > reset-gpios is common DT prop, so Rob asked me to add it in common file. Ah, indeed. Alright, let's document it in the Tegra driver patch, then. Thierry --TxukmIqg3MmZ0Kmh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl0HfiAACgkQ3SOs138+ s6Fn+w/+LYI/OWEFoh9H55Bv5F4iAYdjJsFolI2oa373iKROlpxS3+KJQ1sE3rGO Q+WSuTiuR2mWU98KZtW7wC1bq4tZIFatu1NSWU+GHoOsFK4RFF7ysbgD3i4xIRm9 lnVADCS4XYTjtU6pt8psSiYaIGmTStAVeqJ1qMENChW417flbJzT4EWpuaqsPMy/ OpNvBkJSm/9CpnRcxpc7YIQhdr7EUQtOj/h+r8TNrBACdu1ipH15jps2iv3Co2K8 4SIO89bAEsbp+yH2aaC0jE3sJdXsXKLkd8s57Dhz2jHI7DGK9hUutX2Z/UmIVw0v yuTVrE4peXcNoFDoBDcT+qKSjuanEF6fDIPrXuuvtUapwLzSRHRCMuj0lrtg0vTD Tgiic1Asw6eTM9ruKq+MHJpaD0SQYIUGWOq50bNl1bavmHDdxhEO+aMh/742STpR ULwnCMVgldH2dCQ08PXjzxusIOOCXX0jaDA943LvwPBcQ4xvojyx0FZ/Qe9dygCq Pi/blX9EbqzGJjd8rA+QymTxpmI1UmP0NiXgP/7VqLMc4DFfGkEKf28o6rgucxa4 1Wt8uNxCrptrOYf7ywh1L/xbeDY+q0o9m0oQ1jny9UlCihLNDbS/rbkdYOplDqW5 uWhAqucz679mcX3rCo4GB2CHoHVt0NHPAnm1Y3aIh1EUY8fiZjs= =mels -----END PGP SIGNATURE----- --TxukmIqg3MmZ0Kmh--