From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5296FC31E5F for ; Wed, 19 Jun 2019 16:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28B4321537 for ; Wed, 19 Jun 2019 16:42:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nexedi.com header.i=kirr@nexedi.com header.b="Q5bY2sFh"; dkim=pass (1024-bit key) header.d=mandrillapp.com header.i=@mandrillapp.com header.b="W7qBgaaN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729955AbfFSQm5 (ORCPT ); Wed, 19 Jun 2019 12:42:57 -0400 Received: from mail180-24.suw31.mandrillapp.com ([198.2.180.24]:56391 "EHLO mail180-24.suw31.mandrillapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726839AbfFSQm4 (ORCPT ); Wed, 19 Jun 2019 12:42:56 -0400 X-Greylist: delayed 902 seconds by postgrey-1.27 at vger.kernel.org; Wed, 19 Jun 2019 12:42:56 EDT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=mandrill; d=nexedi.com; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Date:MIME-Version:Content-Type:Content-Transfer-Encoding; i=kirr@nexedi.com; bh=fV7NQkOm47Fi2EjqYPKStwQJEWlNbrKyKdGaNA4YDHc=; b=Q5bY2sFh3B5MqFCAkB0DD53mk0btrJsrX8O1tKvCe2+IlI3r0uzwTwduKO4bKCkyurmpjyY5US9x FfeZbOdOQd48vkbroc1EpECJqgwYrPgUjeC86i5Rhg4TmVBdWnCMKeizXnUNHkBClnmmgX8GFL8E CzlsHit3U6YntaskkAY= Received: from pmta03.mandrill.prod.suw01.rsglab.com (127.0.0.1) by mail180-24.suw31.mandrillapp.com id h19j1022sc0r for ; Wed, 19 Jun 2019 16:27:53 +0000 (envelope-from ) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1560961673; h=From : Subject : To : Cc : Message-Id : References : In-Reply-To : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=fV7NQkOm47Fi2EjqYPKStwQJEWlNbrKyKdGaNA4YDHc=; b=W7qBgaaNz34EPnx48sOEFAXxcFbilh/31qdpg+aLcmxvNJhwGavd3T7rEQfKhxIyh9n+Xu M/LOkpq9g1VinIo9jBl97WB34OIWLCn5HztLIViK1zp3XgNC2uFyKWGWE41JOx2uxKf9jBrA flZ+mpJotM0momx802Um6eQphtI84= From: Kirill Smelkov Subject: Re: [PATCH] pci/switchtec: fix stream_open.cocci warnings (fwd) Received: from [87.98.221.171] by mandrillapp.com id e7a94ac20d0648b393fe8aeaa833f91b; Wed, 19 Jun 2019 16:27:53 +0000 To: Julia Lawall , Sebastian Andrzej Siewior Cc: Kurt Schwemmer , Logan Gunthorpe , Bjorn Helgaas , , , Message-Id: <20190619162713.GA19859@deco.navytux.spb.ru> References: In-Reply-To: X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=31050260.e7a94ac20d0648b393fe8aeaa833f91b X-Mandrill-User: md_31050260 Date: Wed, 19 Jun 2019 16:27:53 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Julia, everyone. On Wed, Jun 19, 2019 at 12:28:47PM +0200, Julia Lawall wrote: > Hi, > > Can you forward this patch to the people below if you think it is > appropriate? Yes, this patch is appropriate. It was actually part of git.kernel.org/linus/c5bf68fe0c86 . It should be safe, (and desirable as it removes a chance for deadlock) to apply it. Sebastian, Kurt, Logan, Bjorn, please consider picking it up. > Could I tell the kbuild people to add you to the CC list for > this semantic patch? Yes, sure. Please feel free to add me to CC list for stream_open.cocci related patches. Kirill > thanks, > julia > > ---------- Forwarded message ---------- > Date: Wed, 19 Jun 2019 18:23:18 +0800 > From: kbuild test robot > To: kbuild@01.org > Cc: Julia Lawall > Subject: [PATCH] pci/switchtec: fix stream_open.cocci warnings > > CC: kbuild-all@01.org > TO: Sebastian Andrzej Siewior > CC: Kurt Schwemmer > CC: Logan Gunthorpe > CC: Bjorn Helgaas > CC: linux-pci@vger.kernel.org > CC: linux-kernel@vger.kernel.org > > From: kbuild test robot > > drivers/pci/switch/switchtec.c:395:1-17: ERROR: switchtec_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. > > Generated by: scripts/coccinelle/api/stream_open.cocci > > Fixes: a3a1e895d4fa ("pci/switchtec: Don't use completion's wait queue") > Signed-off-by: kbuild test robot > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.0.y-rt-rebase > head: 31cc76d5590f5e60c2f26f029e40bc7d0441d93f > commit: a3a1e895d4fa0508e11ac9107ace883a5b2a4d3b [171/305] pci/switchtec: Don't use completion's wait queue > :::::: branch date: 6 days ago > :::::: commit date: 6 days ago > > Please take the patch only if it's a positive warning. Thanks! > > switchtec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/pci/switch/switchtec.c > +++ b/drivers/pci/switch/switchtec.c > @@ -392,7 +392,7 @@ static int switchtec_dev_open(struct ino > return PTR_ERR(stuser); > > filp->private_data = stuser; > - nonseekable_open(inode, filp); > + stream_open(inode, filp); > > dev_dbg(&stdev->dev, "%s: %p\n", __func__, stuser); >