From: Christoph Hellwig <hch@infradead.org>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Bjorn Helgaas <bjorn@helgaas.com>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 1/3] net: fddi: skfp: Rename PCI_REV_ID to PCI_REVISION_ID
Date: Sun, 23 Jun 2019 23:45:45 -0700 [thread overview]
Message-ID: <20190624064545.GA23977@infradead.org> (raw)
In-Reply-To: <20190620180754.15413-2-puranjay12@gmail.com>
On Thu, Jun 20, 2019 at 11:37:52PM +0530, Puranjay Mohan wrote:
> Rename the PCI_REV_ID define to PCI_REVISION_ID in skfbi.h
> and drvfbi.c to make it compatible with the pci_regs.h
> which defines it as PCI_REVISION_ID.
We already cache the revision in struct pci_dev. In doubt you should
use that one.
next prev parent reply other threads:[~2019-06-24 6:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 18:07 [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Puranjay Mohan
2019-06-20 18:07 ` [PATCH v2 1/3] net: fddi: skfp: Rename PCI_REV_ID to PCI_REVISION_ID Puranjay Mohan
2019-06-24 6:45 ` Christoph Hellwig [this message]
2019-06-20 18:07 ` [PATCH v2 2/3] net: fddi: skfp: Include generic PCI definitions Puranjay Mohan
2019-06-20 21:37 ` Bjorn Helgaas
2019-06-20 18:07 ` [PATCH v2 3/3] net: fddi: skfp: Remove unused private " Puranjay Mohan
2019-06-20 21:37 ` Bjorn Helgaas
2019-06-20 18:37 ` [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624064545.GA23977@infradead.org \
--to=hch@infradead.org \
--cc=bjorn@helgaas.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=puranjay12@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).