From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Bjorn Helgaas <bhelgaas@google.com>, Len Brown <lenb@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
Keith Busch <keith.busch@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Alexandru Gagniuc <mr.nuke.me@gmail.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] PCI / ACPI: Use cached ACPI device state to get PCI device power state
Date: Mon, 24 Jun 2019 13:58:32 +0300 [thread overview]
Message-ID: <20190624105832.GE2640@lahna.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0huw-n1m3mz2fEk9y2ejQuT4XYeP8_a-iR+epSq5Wu6yQ@mail.gmail.com>
On Fri, Jun 21, 2019 at 01:56:49PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jun 18, 2019 at 6:19 PM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
>
> Actually, to start with, you can say that the ACPI power state
> returned by acpi_device_get_power() may depend on the configuration of
> ACPI power resources in the system which may change at any time after
> acpi_device_get_power() has returned, unless the reference counters of
> the ACPI power resources in question are set to prevent that from
> happening. Thus it is invalid to use acpi_device_get_power() in
> acpi_pci_get_power_state() the way it is done now and the value of the
> power.state field in the corresponding struct acpi_device object
> (which reflects the ACPI power resources reference counting, among
> other things) should be used instead.
>
> Then you can describe the particular issue below as an example.
>
> IMO that would explain the rationale better here.
Thanks! I'll update the changelog accordingly.
next prev parent reply other threads:[~2019-06-24 10:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 16:18 [PATCH v2 0/3] PCI / ACPI: Handle sibling devices sharing power resources Mika Westerberg
2019-06-18 16:18 ` [PATCH v2 1/3] PCI / ACPI: Use cached ACPI device state to get PCI device power state Mika Westerberg
2019-06-19 21:28 ` Bjorn Helgaas
2019-06-20 8:27 ` Mika Westerberg
2019-06-20 13:16 ` Bjorn Helgaas
2019-06-20 13:37 ` Mika Westerberg
2019-06-20 14:15 ` Bjorn Helgaas
2019-06-21 10:32 ` Rafael J. Wysocki
2019-06-21 13:09 ` Bjorn Helgaas
2019-06-22 8:51 ` Rafael J. Wysocki
2019-06-24 10:57 ` Mika Westerberg
2019-06-24 11:14 ` Rafael J. Wysocki
2019-06-25 9:45 ` Mika Westerberg
2019-06-25 10:00 ` Rafael J. Wysocki
2019-06-25 10:08 ` Mika Westerberg
2019-06-21 11:56 ` Rafael J. Wysocki
2019-06-24 10:58 ` Mika Westerberg [this message]
2019-06-18 16:18 ` [PATCH v2 2/3] ACPI / PM: Introduce concept of a _PR0 dependent device Mika Westerberg
2019-06-19 13:20 ` Rafael J. Wysocki
2019-06-19 13:34 ` Mika Westerberg
2019-06-18 16:18 ` [PATCH v2 3/3] PCI / ACPI: Add _PR0 dependent devices Mika Westerberg
2019-06-19 13:24 ` [PATCH v2 0/3] PCI / ACPI: Handle sibling devices sharing power resources Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624105832.GE2640@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).