From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7683C48BD5 for ; Tue, 25 Jun 2019 07:23:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BC0220656 for ; Tue, 25 Jun 2019 07:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726545AbfFYHXu (ORCPT ); Tue, 25 Jun 2019 03:23:50 -0400 Received: from verein.lst.de ([213.95.11.211]:60268 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726422AbfFYHXt (ORCPT ); Tue, 25 Jun 2019 03:23:49 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id EDBB068B02; Tue, 25 Jun 2019 09:23:17 +0200 (CEST) Date: Tue, 25 Jun 2019 09:23:17 +0200 From: Christoph Hellwig To: Dan Williams Cc: Michal Hocko , Christoph Hellwig , =?iso-8859-1?B?Suly9G1l?= Glisse , Jason Gunthorpe , Ben Skeggs , Linux MM , nouveau@lists.freedesktop.org, Maling list - DRI developers , linux-nvdimm , linux-pci@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 05/22] mm: export alloc_pages_vma Message-ID: <20190625072317.GC30350@lst.de> References: <20190613094326.24093-1-hch@lst.de> <20190613094326.24093-6-hch@lst.de> <20190620191733.GH12083@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Jun 24, 2019 at 11:24:48AM -0700, Dan Williams wrote: > I asked for this simply because it was not exported historically. In > general I want to establish explicit export-type criteria so the > community can spend less time debating when to use EXPORT_SYMBOL_GPL > [1]. > > The thought in this instance is that it is not historically exported > to modules and it is safer from a maintenance perspective to start > with GPL-only for new symbols in case we don't want to maintain that > interface long-term for out-of-tree modules. > > Yes, we always reserve the right to remove / change interfaces > regardless of the export type, but history has shown that external > pressure to keep an interface stable (contrary to > Documentation/process/stable-api-nonsense.rst) tends to be less for > GPL-only exports. Fully agreed. In the end the decision is with the MM maintainers, though, although I'd prefer to keep it as in this series.