From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C804C4321A for ; Fri, 28 Jun 2019 11:36:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F27E208C4 for ; Fri, 28 Jun 2019 11:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726641AbfF1LgF (ORCPT ); Fri, 28 Jun 2019 07:36:05 -0400 Received: from foss.arm.com ([217.140.110.172]:45856 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfF1LgF (ORCPT ); Fri, 28 Jun 2019 07:36:05 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 036A728; Fri, 28 Jun 2019 04:36:04 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F40DC3F718; Fri, 28 Jun 2019 04:36:01 -0700 (PDT) Date: Fri, 28 Jun 2019 12:35:55 +0100 From: Lorenzo Pieralisi To: "Z.q. Hou" Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "l.subrahmanya@mobiveil.co.in" , "shawnguo@kernel.org" , Leo Li , "catalin.marinas@arm.com" , "will.deacon@arm.com" , Mingkai Hu , "M.h. Lian" , Xiaowei Bao Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag MSI_FLAG_MULTI_PCI_MSI Message-ID: <20190628113555.GA21829@e121166-lin.cambridge.arm.com> References: <20190412083635.33626-1-Zhiqiang.Hou@nxp.com> <20190412083635.33626-5-Zhiqiang.Hou@nxp.com> <20190611165935.GA22836@redmoon> <20190612130813.GA15747@redmoon> <20190617093337.GD18020@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Jun 17, 2019 at 10:34:35AM +0000, Z.q. Hou wrote: [...] > > There is nothing obvious. Write what you are fixing in the commit log and I will > > apply the patch, I won't write the commit log for you. Anyone should be able > > to understand why a patch was needed by reading the commit log, it is as > > important as writing the code itself. > > With the flag MSI_FLAG_MULTI_PCI_MSI, when the Endpoint allocates > multiple MSI, it will trigger the "WARN_ON(nr_irqs != 1);" in > mobiveil_irq_msi_domain_alloc(), this is the issue this patch want to > fix. And that's wrong. Marc explained why this controller does not support Multi MSI and that's what should go in the commit log, triggering a WARN_ON is the least of the problems (and the WARN_ON can even be removed after this patch is applied), if it was used as a bandaid to prevent allocating Multi MSI it is even more broken. Lorenzo > Thanks, > Zhiqiang > > > > > Thanks, > > Lorenzo > > > > > Thanks, > > > Zhiqiang > > > > > > > > > > > Lorenzo > > > > > > > > > Subbu, did you test with Endpoint supporting multi MSI? > > > > > > > > > > Thanks, > > > > > Zhiqiang > > > > > > > > > > > > > > > > > Thanks, > > > > > > Lorenzo > > > > > > > > > > > > > Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support") > > > > > > > Signed-off-by: Hou Zhiqiang > > > > > > > Reviewed-by: Minghuan Lian > > > > > > > --- > > > > > > > V5: > > > > > > > - Corrected the subject. > > > > > > > > > > > > > > drivers/pci/controller/pcie-mobiveil.c | 2 +- > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/drivers/pci/controller/pcie-mobiveil.c > > > > > > > b/drivers/pci/controller/pcie-mobiveil.c > > > > > > > index 563210e731d3..a0dd337c6214 100644 > > > > > > > --- a/drivers/pci/controller/pcie-mobiveil.c > > > > > > > +++ b/drivers/pci/controller/pcie-mobiveil.c > > > > > > > @@ -703,7 +703,7 @@ static struct irq_chip > > > > > > > mobiveil_msi_irq_chip = { > > > > > > > > > > > > > > static struct msi_domain_info mobiveil_msi_domain_info = { > > > > > > > .flags = (MSI_FLAG_USE_DEF_DOM_OPS | > > > > > > MSI_FLAG_USE_DEF_CHIP_OPS | > > > > > > > - MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX), > > > > > > > + MSI_FLAG_PCI_MSIX), > > > > > > > .chip = &mobiveil_msi_irq_chip, > > > > > > > }; > > > > > > > > > > > > > > -- > > > > > > > 2.17.1 > > > > > > >