From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-pci@vger.kernel.org, Jean-Jacques Hiblot <jjhiblot@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install`
Date: Fri, 5 Jul 2019 17:23:58 +0100 [thread overview]
Message-ID: <20190705162358.GA3080@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190628133326.18203-1-andriy.shevchenko@linux.intel.com>
On Fri, Jun 28, 2019 at 04:33:26PM +0300, Andy Shevchenko wrote:
> The commit c9a707875053 ("tools pci: Do not delete pcitest.sh in 'make clean'")
> fixed a `make tools clean` issue and simultaneously brought a regression
> to the installation process:
>
> for script in .../tools/pci/pcitest.sh; do \
> install $script .../usr/usr/bin; \
> done
> install: cannot stat '.../tools/pci/pcitest.sh': No such file or directory
>
> Here is the missed part of the fix.
Sigh, hopefully that's the last fix :), Kishon if that's OK mind
ACKing it please ?
Thanks,
Lorenzo
> Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> tools/pci/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/pci/Makefile b/tools/pci/Makefile
> index 6876ee4bd78c..cc4a161ee2cc 100644
> --- a/tools/pci/Makefile
> +++ b/tools/pci/Makefile
> @@ -47,10 +47,10 @@ clean:
>
> install: $(ALL_PROGRAMS)
> install -d -m 755 $(DESTDIR)$(bindir); \
> - for program in $(ALL_PROGRAMS) pcitest.sh; do \
> + for program in $(ALL_PROGRAMS); do \
> install $$program $(DESTDIR)$(bindir); \
> done; \
> - for script in $(ALL_SCRIPTS); do \
> + for script in pcitest.sh; do \
> install $$script $(DESTDIR)$(bindir); \
> done
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-07-05 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 13:33 [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install` Andy Shevchenko
2019-07-05 16:23 ` Lorenzo Pieralisi [this message]
2019-07-05 17:08 ` Andy Shevchenko
2019-07-09 11:18 ` Kishon Vijay Abraham I
2019-07-09 11:38 ` Andy Shevchenko
2019-07-09 11:43 ` Kishon Vijay Abraham I
2019-07-09 11:45 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705162358.GA3080@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=acme@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jjhiblot@ti.com \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).