From: Bjorn Helgaas <helgaas@kernel.org>
To: Jonathan Chocron <jonnyc@amazon.com>
Cc: lorenzo.pieralisi@arm.com, jingoohan1@gmail.com,
gustavo.pimentel@synopsys.com, robh+dt@kernel.org,
mark.rutland@arm.com, dwmw@amazon.co.uk,
benh@kernel.crashing.org, alisaidi@amazon.com, ronenk@amazon.com,
barakw@amazon.com, talel@amazon.com, hanochu@amazon.com,
hhhawa@amazon.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/8] PCI/VPD: Add VPD release quirk for Amazon Annapurna Labs host bridge
Date: Fri, 12 Jul 2019 08:10:08 -0500 [thread overview]
Message-ID: <20190712131008.GC46935@google.com> (raw)
In-Reply-To: <20190710164519.17883-4-jonnyc@amazon.com>
On Thu, Jul 11, 2019 at 05:55:56PM +0300, Jonathan Chocron wrote:
> The Amazon Annapurna Labs pcie host bridge exposes the VPD capability,
> but there is no actual support for it.
s/pcie/PCIe/
s/host bridge/Root Port/
> The reason for not using the already existing quirk_blacklist_vpd()
> is that, although this fails pci_vpd_read/write, the 'vpd' sysfs
> entry still exists. When running lspci -vv, for example, this
> results in the following error:
>
> pcilib: sysfs_read_vpd: read failed: Input/output error
>
> This quirk removes the sysfs entry, which avoids the error print.
>
> Signed-off-by: Jonathan Chocron <jonnyc@amazon.com>
> ---
> drivers/pci/vpd.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c
> index 4963c2e2bd4c..b594b2895ffe 100644
> --- a/drivers/pci/vpd.c
> +++ b/drivers/pci/vpd.c
> @@ -644,4 +644,16 @@ static void quirk_chelsio_extend_vpd(struct pci_dev *dev)
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_CHELSIO, PCI_ANY_ID,
> quirk_chelsio_extend_vpd);
>
> +static void quirk_al_vpd_release(struct pci_dev *dev)
> +{
> + if (dev->vpd) {
> + pci_vpd_release(dev);
> + dev->vpd = NULL;
> + pci_warn(dev, FW_BUG "Annapurna Labs pcie quirk - Releasing VPD capability (No support for VPD read/write transactions)\n");
The "Annapurna Labs pcie quirk" text is superfluous.
> + }
> +}
> +
> +DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031,
> + PCI_CLASS_BRIDGE_PCI, 8, quirk_al_vpd_release);
Why DECLARE_PCI_FIXUP_CLASS_FINAL()? See comments on the MSI-X quirk
patch.
> +
> #endif
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2019-07-12 13:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:50 [PATCH 0/8] Amazon's Annapurna Labs DT-based PCIe host controller driver Jonathan Chocron
2019-07-11 14:45 ` [PATCH 5/8] dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding Jonathan Chocron
2019-07-11 7:12 ` Shenhar, Talel
2019-07-11 9:32 ` Lorenzo Pieralisi
2019-07-11 15:44 ` Chocron, Jonathan
2019-07-11 14:53 ` [PATCH 1/8] PCI: Add Amazon's Annapurna Labs vendor ID Jonathan Chocron
2019-07-12 13:04 ` Bjorn Helgaas
2019-07-11 14:55 ` [PATCH 2/8] PCI: Add ACS quirk for Amazon Annapurna Labs root ports Jonathan Chocron
2019-07-11 14:55 ` [PATCH 3/8] PCI/VPD: Add VPD release quirk for Amazon Annapurna Labs host bridge Jonathan Chocron
2019-07-12 13:10 ` Bjorn Helgaas [this message]
2019-07-14 15:08 ` Chocron, Jonathan
2019-07-11 14:56 ` [PATCH 4/8] PCI: Add quirk to disable MSI support for Amazon's " Jonathan Chocron
2019-07-12 13:04 ` Bjorn Helgaas
2019-07-14 15:09 ` Chocron, Jonathan
2019-07-14 22:54 ` Benjamin Herrenschmidt
2019-07-11 14:57 ` [PATCH 6/8] PCI: al: Add support for DW based driver type Jonathan Chocron
2019-07-12 13:42 ` Bjorn Helgaas
2019-07-15 15:18 ` Chocron, Jonathan
2019-07-11 14:57 ` [PATCH 7/8] PCI: dw: Add validation that PCIe core is set to correct mode Jonathan Chocron
2019-07-11 14:57 ` [PATCH 8/8] PCI: dw: Add support for PCI_PROBE_ONLY/PCI_REASSIGN_ALL_BUS flags Jonathan Chocron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712131008.GC46935@google.com \
--to=helgaas@kernel.org \
--cc=alisaidi@amazon.com \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gustavo.pimentel@synopsys.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jingoohan1@gmail.com \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).