From: Bjorn Helgaas <helgaas@kernel.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Kelsey Skunberg <skunberg.kelsey@gmail.com>,
linux-pci@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] PCI: Remove functions not called in include/linux/pci.h
Date: Mon, 15 Jul 2019 18:37:17 -0500 [thread overview]
Message-ID: <20190715233717.GA79424@google.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1907152138120.2564@felia>
On Mon, Jul 15, 2019 at 09:42:47PM +0200, Lukas Bulwahn wrote:
> On Mon, 15 Jul 2019, Kelsey Skunberg wrote:
>
> > Remove the following uncalled functions from include/linux/pci.h:
> >
> > pci_block_cfg_access()
> > pci_block_cfg_access_in_atomic()
> > pci_unblock_cfg_access()
> >
> > Functions were added in patch fb51ccbf217c "PCI: Rework config space
> > blocking services", ...
> Also note that commits are referred to with this format:
>
> commit <12-character sha prefix> ("<commit message>")
FWIW, I use this shell alias to generate these references:
gsr is aliased to `git --no-pager show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"'
$ gsr fb51ccb
fb51ccbf217c ("PCI: Rework config space blocking services")
Documentation/process/submitting-patches.rst mentions a 12-char (at
least) SHA-1 but the e21d2170f36 example shows a *20*-char SHA-1,
which seems excessive to me.
I personally skip the word "commit" because I figure it's pretty
obvious what it is, but it's fine either way.
Bjorn
next prev parent reply other threads:[~2019-07-15 23:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 17:56 [PATCH] PCI: Remove functions not called in include/linux/pci.h Kelsey
2019-07-15 18:13 ` [PATCH v2] " Kelsey Skunberg
2019-07-15 19:42 ` [Linux-kernel-mentees] " Lukas Bulwahn
2019-07-15 20:19 ` Kelsey Skunberg
2019-07-15 23:37 ` Bjorn Helgaas [this message]
2019-07-16 3:57 ` Kelsey Skunberg
2019-07-15 20:34 ` [PATCH v3] " Kelsey Skunberg
2019-07-16 4:58 ` [Linux-kernel-mentees] " Lukas Bulwahn
2019-07-23 23:34 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715233717.GA79424@google.com \
--to=helgaas@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=skunberg.kelsey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).