From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: "Derrick, Jonathan" <jonathan.derrick@intel.com>
Cc: "sashal@kernel.org" <sashal@kernel.org>,
"Busch, Keith" <keith.busch@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"helgaas@kernel.org" <helgaas@kernel.org>
Subject: Re: [PATCH] PCI/VMD: Fix config addressing with bus offsets
Date: Tue, 23 Jul 2019 10:32:51 +0100 [thread overview]
Message-ID: <20190723093251.GA12867@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <1ec9408fabb2178181f02b7ddbb2b22604c49417.camel@intel.com>
On Mon, Jul 22, 2019 at 04:02:18PM +0000, Derrick, Jonathan wrote:
> On Fri, 2019-06-21 at 15:28 +0100, Lorenzo Pieralisi wrote:
> > [dropped CC stable]
> >
> > On Tue, Jun 11, 2019 at 03:15:38PM -0600, Jon Derrick wrote:
> > > VMD config space addressing relies on mapping the BDF of the target into
> > > the VMD config bar. When using bus number offsets to number the VMD
> > > domain, the offset needs to be ignored in order to correctly map devices
> > > to their config space.
> > >
> > > Fixes: 2a5a9c9a20f9 ("PCI: vmd: Add offset to bus numbers if necessary")
> > > Cc: <stable@vger.kernel.org> # v4.19
> > > Cc: <stable@vger.kernel.org> # v4.18
> >
> > Hi Jon,
> >
> > that's not how stable should be handled. You should always start
> > by fixing mainline and if there are backports to be fixed too you
> > should add patch dependencies in the CC area, see:
> >
> > Documentation/process/stable-kernel-rules.rst
> >
> > Never add stable to the CC list in the email header, only in the
> > commit log.
> >
> > When your patch hits mainline it will trickle back into stable,
> > if you specified dependencies as described above there is nothing
> > to do.
> >
> > Thanks,
> > Lorenzo
> >
>
> Besides the stable issue, can we get this into 5.3?
Usually we send fixes at -rc for patches that were merged in the
previous merge window; this fix is not one of those so I think
we will send it for v5.4 unless it is very urgent.
We should still update stable info in the log appropriately
before queuing it.
Thanks,
Lorenzo
next prev parent reply other threads:[~2019-07-23 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 21:15 [PATCH] PCI/VMD: Fix config addressing with bus offsets Jon Derrick
2019-06-21 14:28 ` Lorenzo Pieralisi
2019-06-24 18:12 ` Derrick, Jonathan
2019-07-22 16:02 ` Derrick, Jonathan
2019-07-23 9:32 ` Lorenzo Pieralisi [this message]
2019-07-23 15:12 ` Derrick, Jonathan
2019-07-24 11:11 ` Lorenzo Pieralisi
2019-07-24 17:47 ` Derrick, Jonathan
-- strict thread matches above, loose matches on Subject: below --
2019-06-07 20:00 Jon Derrick
[not found] ` <20190610151839.EC55620862@mail.kernel.org>
2019-06-10 15:34 ` Derrick, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723093251.GA12867@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).