From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6AD3C0650F for ; Mon, 5 Aug 2019 12:34:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A7482087B for ; Mon, 5 Aug 2019 12:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727349AbfHEMey (ORCPT ); Mon, 5 Aug 2019 08:34:54 -0400 Received: from mga01.intel.com ([192.55.52.88]:21145 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbfHEMey (ORCPT ); Mon, 5 Aug 2019 08:34:54 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Aug 2019 05:34:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,349,1559545200"; d="scan'208";a="192410973" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 05 Aug 2019 05:34:50 -0700 Received: by lahna (sSMTP sendmail emulation); Mon, 05 Aug 2019 15:34:50 +0300 Date: Mon, 5 Aug 2019 15:34:50 +0300 From: Mika Westerberg To: Nicholas Johnson Cc: Logan Gunthorpe , Bjorn Helgaas , Benjamin Herrenschmidt , "linux-pci@vger.kernel.org" Subject: Re: Possible PCI Regression Linux 5.3-rc1 Message-ID: <20190805123450.GM2640@lahna.fi.intel.com> References: <20190724133814.GA194025@google.com> <4f5afb8e-9013-980f-0553-c687d17ed8d5@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi, On Sun, Aug 04, 2019 at 08:47:43AM +0000, Nicholas Johnson wrote: > Reversing the following commit solves the issue: > > commit c2bf1fc212f7e6f25ace1af8f0b3ac061ea48ba5 > Author: Mika Westerberg > PCI: Add missing link delays required by the PCIe spec > > Mika, care to weigh in (assuming you are back from four weeks leave)? I'm back now. > Clearly this creates delays in "lspci -vt" in some Thunderbolt systems, > but not all - otherwise you would have caught it. You mentioned Ice Lake > in the commit log so perhaps it works fine on Ice Lake. I also tried it on other systems but it may be that something is missing. Can you add "pciepordrv.dyndbg" to the kernel command line (or change the dev_dbg() in wait_for_downstream_link() to dev_info() instead and attach the dmesg along with full 'sudo lspci -vv' output to the following bugzilla (as I think they are the same issue in the end): https://bugzilla.kernel.org/show_bug.cgi?id=204413 Thanks!