From: Bjorn Helgaas <helgaas@kernel.org>
To: Denis Efremov <efremov@linux.com>
Cc: Sebastian Ott <sebott@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
linux-pci@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/pci: PCI_IOV_RESOURCES loop refactoring in zpci_map_resources
Date: Tue, 6 Aug 2019 15:48:01 -0500 [thread overview]
Message-ID: <20190806204801.GV151852@google.com> (raw)
In-Reply-To: <20190806160137.29275-1-efremov@linux.com>
Thanks for the patch!
Sebastian may have silently fixed this, but for future reference,
$ git log --oneline arch/s390/pci/pci.c
c7ff0e918a7c s390/pci: deal with devices that have no support for MIO instructions
dcd33b23c9f3 s390/pci: fix assignment of bus resources
56271303808f s390/pci: add parameter to disable usage of MIO instructions
71ba41c9b1d9 s390/pci: provide support for MIO instructions
81deca12c202 s390/pci: move io address mapping code to pci_insn.c
fbfe07d440f2 s390/pci: add parameter to force floating irqs
c840927cf5f2 s390/pci: move everything irq related to pci_irq.c
066ee72aecdc s390/pci: remove unused define
...
shows that the typical style there is to start the subject with a verb
so it's an imperative sentence.
On Tue, Aug 06, 2019 at 07:01:37PM +0300, Denis Efremov wrote:
> This patch alters the for loop iteration scheme in zpci_map_resources
> to make it more usual. Thus, the patch generalizes the style for
> PCI_IOV_RESOURCES iteration and improves readability.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
> arch/s390/pci/pci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c
> index b0e3b9a0e488..c7fea9bea8cb 100644
> --- a/arch/s390/pci/pci.c
> +++ b/arch/s390/pci/pci.c
> @@ -431,13 +431,13 @@ static void zpci_map_resources(struct pci_dev *pdev)
> }
>
> #ifdef CONFIG_PCI_IOV
> - i = PCI_IOV_RESOURCES;
> + for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) {
> + int bar = i + PCI_IOV_RESOURCES;
>
> - for (; i < PCI_SRIOV_NUM_BARS + PCI_IOV_RESOURCES; i++) {
> - len = pci_resource_len(pdev, i);
> + len = pci_resource_len(pdev, bar);
> if (!len)
> continue;
> - pdev->resource[i].parent = &iov_res;
> + pdev->resource[bar].parent = &iov_res;
> }
> #endif
> }
> --
> 2.21.0
>
prev parent reply other threads:[~2019-08-06 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 16:01 [PATCH] s390/pci: PCI_IOV_RESOURCES loop refactoring in zpci_map_resources Denis Efremov
2019-08-06 18:11 ` Sebastian Ott
2019-08-06 20:48 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806204801.GV151852@google.com \
--to=helgaas@kernel.org \
--cc=efremov@linux.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sebott@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).