From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EDDBC32753 for ; Wed, 14 Aug 2019 10:11:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 620432067D for ; Wed, 14 Aug 2019 10:11:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725955AbfHNKLH (ORCPT ); Wed, 14 Aug 2019 06:11:07 -0400 Received: from foss.arm.com ([217.140.110.172]:51474 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbfHNKLH (ORCPT ); Wed, 14 Aug 2019 06:11:07 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A79F3344; Wed, 14 Aug 2019 03:11:06 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6EC253F706; Wed, 14 Aug 2019 03:11:05 -0700 (PDT) Date: Wed, 14 Aug 2019 11:11:00 +0100 From: Lorenzo Pieralisi To: Xiaowei Bao Cc: "M.h. Lian" , Mingkai Hu , Roy Zang , "bhelgaas@google.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCHv6 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver. Message-ID: <20190814101100.GA29414@e121166-lin.cambridge.arm.com> References: <20190814020330.12133-1-xiaowei.bao@nxp.com> <20190814092952.GA26840@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Aug 14, 2019 at 09:48:00AM +0000, Xiaowei Bao wrote: > > > > -----Original Message----- > > From: Lorenzo Pieralisi > > Sent: 2019年8月14日 17:30 > > To: Xiaowei Bao > > Cc: M.h. Lian ; Mingkai Hu > > ; Roy Zang ; > > bhelgaas@google.com; linuxppc-dev@lists.ozlabs.org; > > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org > > Subject: Re: [PATCHv6 1/2] PCI: layerscape: Add the bar_fixed_64bit property > > in EP driver. Do not quote the email header in your replies. > > I asked you to remove the period at the end of the patch $SUBJECT and you > > did not, either you do not read what I write or explain me what's going on. > Sorry, I didn't understand the meaning of period correctly before. > > > > On Wed, Aug 14, 2019 at 10:03:29AM +0800, Xiaowei Bao wrote: > > > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is > > > 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set > > > the bar_fixed_64bit with 0x14. > > > > > > Signed-off-by: Xiaowei Bao > > > > Kishon ACK'ed this patch and you have not carried his tag. > > > > I will make these changes but that's the last time I do that for you. > Thanks a lot, your means is that I don't need to send the v7 patch and you help me to > Correct this patch, yes? Thanks a lot for your help about the rules of the upstream. I will > Correct this error next time. ^.^ I fixed that up and pushed out, pci/layerscape, for v5.4. Thanks, Lorenzo > > Lorenzo > > > > > --- > > > v2: > > > - Replace value 0x14 with a macro. > > > v3: > > > - No change. > > > v4: > > > - send the patch again with '--to'. > > > v5: > > > - fix the commit message. > > > v6: > > > - remove the [EXT] tag of the $SUBJECT in email. > > > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > index be61d96..ca9aa45 100644 > > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > @@ -44,6 +44,7 @@ static const struct pci_epc_features > > ls_pcie_epc_features = { > > > .linkup_notifier = false, > > > .msi_capable = true, > > > .msix_capable = false, > > > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > > > }; > > > > > > static const struct pci_epc_features* > > > -- > > > 2.9.5 > > >