From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7A93C433FF for ; Thu, 15 Aug 2019 10:48:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94CB621744 for ; Thu, 15 Aug 2019 10:48:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731030AbfHOKsK (ORCPT ); Thu, 15 Aug 2019 06:48:10 -0400 Received: from foss.arm.com ([217.140.110.172]:41804 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730029AbfHOKsJ (ORCPT ); Thu, 15 Aug 2019 06:48:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F2DAA28; Thu, 15 Aug 2019 03:48:08 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 685A23F694; Thu, 15 Aug 2019 03:48:07 -0700 (PDT) Date: Thu, 15 Aug 2019 11:47:56 +0100 From: Lorenzo Pieralisi To: Randy Dunlap Cc: linux-pci , LKML , Matthew Wilcox , Jake Oshins , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Stephen Hemminger , Sasha Levin , Bjorn Helgaas , Dexuan Cui Subject: Re: [PATCH] PCI: pci-hyperv: fix build errors on non-SYSFS config Message-ID: <20190815104748.GB9511@e121166-lin.cambridge.arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jul 12, 2019 at 08:53:19AM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build errors when building almost-allmodconfig but with SYSFS > not set (not enabled). Fixes these build errors: > > ERROR: "pci_destroy_slot" [drivers/pci/controller/pci-hyperv.ko] undefined! > ERROR: "pci_create_slot" [drivers/pci/controller/pci-hyperv.ko] undefined! > > drivers/pci/slot.o is only built when SYSFS is enabled, so > pci-hyperv.o has an implicit dependency on SYSFS. > Make that explicit. > > Also, depending on X86 && X86_64 is not needed, so just change that > to depend on X86_64. > > Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot > information") Fixed line break on Fixes tag, FYI. > Signed-off-by: Randy Dunlap > Cc: Matthew Wilcox > Cc: Jake Oshins > Cc: "K. Y. Srinivasan" > Cc: Haiyang Zhang > Cc: Stephen Hemminger > Cc: Stephen Hemminger > Cc: Sasha Levin > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Cc: linux-hyperv@vger.kernel.org > Cc: Dexuan Cui > --- > v3: corrected Fixes: tag [Dexuan Cui ] > This is the Microsoft-preferred version of the patch. > > drivers/pci/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to pci/hv for v5.4. Thanks, Lorenzo > --- lnx-52.orig/drivers/pci/Kconfig > +++ lnx-52/drivers/pci/Kconfig > @@ -181,7 +181,7 @@ config PCI_LABEL > > config PCI_HYPERV > tristate "Hyper-V PCI Frontend" > - depends on X86 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN && X86_64 > + depends on X86_64 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN && SYSFS > help > The PCI device frontend driver allows the kernel to import arbitrary > PCI devices from a PCI backend to support PCI driver domains. > >