Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] x86/PCI: Add missing SPDX license header.
@ 2019-08-19  6:06 Krzysztof Wilczynski
  2019-08-27 23:24 ` Bjorn Helgaas
  2019-08-28 13:53 ` [PATCH v2] x86/PCI: Correct warnings about missing or incorrect SPDX license headers Krzysztof Wilczynski
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Wilczynski @ 2019-08-19  6:06 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
	Daniel J Blueman, x86, linux-pci, linux-kernel

Add the missing "SPDX-License-Identifier" license header to the
arch/x86/pci/numachip.c.  Use GPL-2.0 identifier derived using
the comment mentioning license from the top of the file.

Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
---
 arch/x86/pci/numachip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/pci/numachip.c b/arch/x86/pci/numachip.c
index 2e565e65c893..b73157e834e0 100644
--- a/arch/x86/pci/numachip.c
+++ b/arch/x86/pci/numachip.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * This file is subject to the terms and conditions of the GNU General Public
  * License.  See the file "COPYING" in the main directory of this archive
-- 
2.22.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] x86/PCI: Add missing SPDX license header.
  2019-08-19  6:06 [PATCH] x86/PCI: Add missing SPDX license header Krzysztof Wilczynski
@ 2019-08-27 23:24 ` Bjorn Helgaas
  2019-08-28 10:32   ` Krzysztof Wilczynski
  2019-08-28 13:53 ` [PATCH v2] x86/PCI: Correct warnings about missing or incorrect SPDX license headers Krzysztof Wilczynski
  1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2019-08-27 23:24 UTC (permalink / raw)
  To: Krzysztof Wilczynski
  Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
	Daniel J Blueman, x86, linux-pci, linux-kernel

On Mon, Aug 19, 2019 at 08:06:24AM +0200, Krzysztof Wilczynski wrote:
> Add the missing "SPDX-License-Identifier" license header to the
> arch/x86/pci/numachip.c.  Use GPL-2.0 identifier derived using
> the comment mentioning license from the top of the file.
> 
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
> ---
>  arch/x86/pci/numachip.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/pci/numachip.c b/arch/x86/pci/numachip.c
> index 2e565e65c893..b73157e834e0 100644
> --- a/arch/x86/pci/numachip.c
> +++ b/arch/x86/pci/numachip.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   * This file is subject to the terms and conditions of the GNU General Public
>   * License.  See the file "COPYING" in the main directory of this archive

You can remove this license text at the same time as in 8cfab3cf63cf
("PCI: Add SPDX GPL-2.0 to replace GPL v2 boilerplate").

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] x86/PCI: Add missing SPDX license header.
  2019-08-27 23:24 ` Bjorn Helgaas
@ 2019-08-28 10:32   ` Krzysztof Wilczynski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Wilczynski @ 2019-08-28 10:32 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Krzysztof Wilczynski, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H. Peter Anvin, Daniel J Blueman, x86,
	linux-pci, linux-kernel

Hello Bjorn,

Thank you for the feedback.

[...]
>>  +// SPDX-License-Identifier: GPL-2.0
>>   /*
>>    * This file is subject to the terms and conditions of the GNU 
>> General Public
>>    * License.  See the file "COPYING" in the main directory of this 
>> archive
> 
> You can remove this license text at the same time as in 8cfab3cf63cf
> ("PCI: Add SPDX GPL-2.0 to replace GPL v2 boilerplate").

Will do. I am going to send an updated v2 that takes care about this.

Krzysztof



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] x86/PCI: Correct warnings about missing or incorrect SPDX license headers.
  2019-08-19  6:06 [PATCH] x86/PCI: Add missing SPDX license header Krzysztof Wilczynski
  2019-08-27 23:24 ` Bjorn Helgaas
@ 2019-08-28 13:53 ` Krzysztof Wilczynski
  1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Wilczynski @ 2019-08-28 13:53 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
	Daniel J Blueman, x86, linux-pci, linux-kernel

Add the missing "SPDX-License-Identifier" license header
to the arch/x86/pci/numachip.c (use the GPL-2.0 identifier
derived using the comment mentioning license from the
top of the file), and remove license boilerplate as per
a similar commit 8cfab3cf63cf ("PCI: Add SPDX GPL-2.0 to
replace GPL v2 boilerplate").

Correct existing SPDX license header in the files
drivers/pci/controller/pcie-cadence.h and
drivers/pci/controller/pcie-rockchip.h to use
correct comment style as per the section 2 "Style"
of the "Linux kernel licensing rules" (see:
Documentation/process/license-rules.rst).

Both changes will resolve the following checkpatch.pl
script warning:

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
---
Changes in v2:
  Update wording and mention checkpatch.pl script warnings.
  Add two C header files to which the fix also applies.

 arch/x86/pci/numachip.c                | 5 +----
 drivers/pci/controller/pcie-cadence.h  | 2 +-
 drivers/pci/controller/pcie-rockchip.h | 2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/x86/pci/numachip.c b/arch/x86/pci/numachip.c
index 2e565e65c893..01a085d9135a 100644
--- a/arch/x86/pci/numachip.c
+++ b/arch/x86/pci/numachip.c
@@ -1,8 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
- * This file is subject to the terms and conditions of the GNU General Public
- * License.  See the file "COPYING" in the main directory of this archive
- * for more details.
- *
  * Numascale NumaConnect-specific PCI code
  *
  * Copyright (C) 2012 Numascale AS. All rights reserved.
diff --git a/drivers/pci/controller/pcie-cadence.h b/drivers/pci/controller/pcie-cadence.h
index ae6bf2a2b3d3..f1cba3931b99 100644
--- a/drivers/pci/controller/pcie-cadence.h
+++ b/drivers/pci/controller/pcie-cadence.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 // Copyright (c) 2017 Cadence
 // Cadence PCIe controller driver.
 // Author: Cyrille Pitchen <cyrille.pitchen@free-electrons.com>
diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controller/pcie-rockchip.h
index 8e87a059ce73..53e4f9e59624 100644
--- a/drivers/pci/controller/pcie-rockchip.h
+++ b/drivers/pci/controller/pcie-rockchip.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Rockchip AXI PCIe controller driver
  *
-- 
2.22.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19  6:06 [PATCH] x86/PCI: Add missing SPDX license header Krzysztof Wilczynski
2019-08-27 23:24 ` Bjorn Helgaas
2019-08-28 10:32   ` Krzysztof Wilczynski
2019-08-28 13:53 ` [PATCH v2] x86/PCI: Correct warnings about missing or incorrect SPDX license headers Krzysztof Wilczynski

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org linux-pci@archiver.kernel.org
	public-inbox-index linux-pci


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox