From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: sashal@kernel.org, saeedm@mellanox.com, leon@kernel.org,
eranbe@mellanox.com, lorenzo.pieralisi@arm.com,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
kys@microsoft.com, sthemmin@microsoft.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next,v2 2/6] PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface
Date: Tue, 20 Aug 2019 12:29:25 -0700 (PDT) [thread overview]
Message-ID: <20190820.122925.1080288470348205792.davem@davemloft.net> (raw)
In-Reply-To: <1566242976-108801-3-git-send-email-haiyangz@microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Mon, 19 Aug 2019 19:30:47 +0000
> +static void __exit exit_hv_pci_intf(void)
> +{
> + pr_info("unloaded\n");
> +}
> +
> +static int __init init_hv_pci_intf(void)
> +{
> + pr_info("loaded\n");
> +
Clogging up the logs with useless messages like this is inappropriate.
Please remove these pr_info() calls.
Also, all of these symbols should probably be GPL exported.
next prev parent reply other threads:[~2019-08-20 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 19:30 [PATCH net-next,v2 0/6] Add software backchannel and mlx5e HV VHCA stats Haiyang Zhang
2019-08-19 19:30 ` [PATCH net-next,v2 1/6] PCI: hv: Add a paravirtual backchannel in software Haiyang Zhang
2019-08-19 19:30 ` [PATCH net-next,v2 2/6] PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface Haiyang Zhang
2019-08-20 19:29 ` David Miller [this message]
2019-08-20 23:00 ` Haiyang Zhang
2019-08-19 19:30 ` [PATCH net-next,v2 3/6] net/mlx5: Add wrappers for HyperV PCIe operations Haiyang Zhang
2019-08-19 19:30 ` [PATCH net-next,v2 4/6] net/mlx5: Add HV VHCA infrastructure Haiyang Zhang
2019-08-19 19:30 ` [PATCH net-next,v2 5/6] net/mlx5: Add HV VHCA control agent Haiyang Zhang
2019-08-19 19:30 ` [PATCH net-next,v2 6/6] net/mlx5e: Add mlx5e HV VHCA stats agent Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820.122925.1080288470348205792.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhelgaas@google.com \
--cc=eranbe@mellanox.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).