From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Logan Gunthorpe <logang@deltatee.com>,
linux-pci@vger.kernel.org, Moritz Fischer <mdf@kernel.org>,
Wu Hao <hao.wu@intel.com>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component
Date: Tue, 20 Aug 2019 12:58:20 +0300 [thread overview]
Message-ID: <20190820095820.GD19908@lahna.fi.intel.com> (raw)
In-Reply-To: <20190819235245.GX253360@google.com>
On Mon, Aug 19, 2019 at 06:52:45PM -0500, Bjorn Helgaas wrote:
> > Right, it looks like we need some sort of flag there anyway.
>
> Does this mean you're looking at getting rid of "has_secondary_link",
> you think it's impossible, or you think it's not worth trying?
I was of thinking that we need some flag anyway for the downstream port
(such as has_secondary_link) that tells us the which side of the port
the link is.
> I'm pretty sure we could get rid of it by looking upstream, but I
> haven't actually tried it.
So if we are downstream port, look at the parent and if it is also
downstream port (or root port) we change the type to upstream port
accordingly? That might work.
Another option may be to just add a quirk for these ports.
Only concern for both is that we have functions that rely on the type
such as pcie_capability_read_word() so if we change the type do we end
up breaking something? I did not check too closely, though.
I'm willing to cook a patch that fixes this once we have some consensus
what it should do ;-)
next prev parent reply other threads:[~2019-08-20 9:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 10:49 [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component Mika Westerberg
2019-07-03 12:30 ` Mika Westerberg
2019-07-03 13:39 ` Bjorn Helgaas
2019-07-03 15:03 ` Mika Westerberg
2019-08-01 21:53 ` Bjorn Helgaas
2019-08-04 11:51 ` Wu Hao
2019-08-06 10:12 ` Mika Westerberg
2019-08-19 23:52 ` Bjorn Helgaas
2019-08-20 9:58 ` Mika Westerberg [this message]
2019-08-20 14:17 ` Bjorn Helgaas
2019-08-21 7:28 ` Mika Westerberg
2019-08-21 14:37 ` Mika Westerberg
2019-08-21 19:01 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820095820.GD19908@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=hao.wu@intel.com \
--cc=helgaas@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).