From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7BE8C3A5A2 for ; Fri, 23 Aug 2019 15:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FE5B21019 for ; Fri, 23 Aug 2019 15:41:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726876AbfHWPlT (ORCPT ); Fri, 23 Aug 2019 11:41:19 -0400 Received: from foss.arm.com ([217.140.110.172]:36492 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726824AbfHWPlT (ORCPT ); Fri, 23 Aug 2019 11:41:19 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB36928; Fri, 23 Aug 2019 08:41:18 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 686353F246; Fri, 23 Aug 2019 08:41:17 -0700 (PDT) Date: Fri, 23 Aug 2019 16:41:15 +0100 From: Lorenzo Pieralisi To: Vidya Sagar Cc: bhelgaas@google.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com Subject: Re: [PATCH] PCI: tegra: Don't print an error on -EPROBE_DEFER Message-ID: <20190823154115.GB28344@e121166-lin.cambridge.arm.com> References: <20190823151832.14427-1-vidyas@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190823151832.14427-1-vidyas@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Aug 23, 2019 at 08:48:32PM +0530, Vidya Sagar wrote: > APIs like devm_regulator_get() and devm_phy_get() have the potential to > return -EPROBE_DEFER when the respective sub-systems are not ready yet. > So avoid printing an error message as .probe() will be tried out again > at a later point of time anyway. > > Signed-off-by: Vidya Sagar > --- > drivers/pci/controller/dwc/pcie-tegra194.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) Squashed in pci/tegra, thanks. Lorenzo > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > index fc0dbeb31d78..c730986ed34d 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -1368,9 +1368,11 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) > > pcie->pex_ctl_supply = devm_regulator_get(dev, "vddio-pex-ctl"); > if (IS_ERR(pcie->pex_ctl_supply)) { > - dev_err(dev, "Failed to get regulator: %ld\n", > - PTR_ERR(pcie->pex_ctl_supply)); > - return PTR_ERR(pcie->pex_ctl_supply); > + ret = PTR_ERR(pcie->pex_ctl_supply); > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "Failed to get regulator: %ld\n", > + PTR_ERR(pcie->pex_ctl_supply)); > + return ret; > } > > pcie->core_clk = devm_clk_get(dev, "core"); > @@ -1412,7 +1414,8 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) > kfree(name); > if (IS_ERR(phys[i])) { > ret = PTR_ERR(phys[i]); > - dev_err(dev, "Failed to get PHY: %d\n", ret); > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "Failed to get PHY: %d\n", ret); > return ret; > } > } > -- > 2.17.1 >