From: Bjorn Helgaas <helgaas@kernel.org>
To: Krzysztof Wilczynski <kw@linux.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Remove the use of printk_ratelimit() in pci.c
Date: Tue, 27 Aug 2019 18:25:18 -0500 [thread overview]
Message-ID: <20190827232518.GJ9987@google.com> (raw)
In-Reply-To: <20190825224616.8021-1-kw@linux.com>
On Mon, Aug 26, 2019 at 12:46:16AM +0200, Krzysztof Wilczynski wrote:
> Do not use printk_ratelimit() in drivers/pci/pci.c as it shares the
> rate limiting state with all other callers to the printk_ratelimit().
>
> Add pci_info_ratelimited macro similar to pci_notice_ratelimited
> added in the commit a88a7b3eb076 ("vfio: Use dev_printk() when
> possible") and use it instead of pr_info inside the if-statement.
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Applied to pci/misc for v5.4, thanks!
> ---
> drivers/pci/pci.c | 4 ++--
> include/linux/pci.h | 3 +++
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index f20a3de57d21..e3d190d003c5 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -890,8 +890,8 @@ static int pci_raw_set_power_state(struct pci_dev *dev, pci_power_t state)
>
> pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr);
> dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK);
> - if (dev->current_state != state && printk_ratelimit())
> - pci_info(dev, "Refused to change power state, currently in D%d\n",
> + if (dev->current_state != state)
> + pci_info_ratelimited(dev, "Refused to change power state, currently in D%d\n",
> dev->current_state);
>
> /*
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 463486016290..73ce8d908322 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -2367,4 +2367,7 @@ void pci_uevent_ers(struct pci_dev *pdev, enum pci_ers_result err_type);
> #define pci_notice_ratelimited(pdev, fmt, arg...) \
> dev_notice_ratelimited(&(pdev)->dev, fmt, ##arg)
>
> +#define pci_info_ratelimited(pdev, fmt, arg...) \
> + dev_info_ratelimited(&(pdev)->dev, fmt, ##arg)
> +
> #endif /* LINUX_PCI_H */
> --
> 2.22.1
>
prev parent reply other threads:[~2019-08-27 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 22:46 [PATCH] PCI: Remove the use of printk_ratelimit() in pci.c Krzysztof Wilczynski
2019-08-27 23:25 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827232518.GJ9987@google.com \
--to=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).