From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CD1EC3A5A1 for ; Wed, 28 Aug 2019 21:09:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0F4422CED for ; Wed, 28 Aug 2019 21:09:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726877AbfH1VJ5 (ORCPT ); Wed, 28 Aug 2019 17:09:57 -0400 Received: from foss.arm.com ([217.140.110.172]:36406 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbfH1VJ5 (ORCPT ); Wed, 28 Aug 2019 17:09:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8A518337; Wed, 28 Aug 2019 14:09:56 -0700 (PDT) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3A3A3F718; Wed, 28 Aug 2019 14:09:55 -0700 (PDT) Date: Wed, 28 Aug 2019 22:09:54 +0100 From: Andrew Murray To: Thierry Reding Cc: Lorenzo Pieralisi , Bjorn Helgaas , linux-pci@vger.kernel.org, Shawn Guo Subject: Re: [PATCH 4/5] PCI: histb: Properly handle optional regulators Message-ID: <20190828210953.GF14582@e119886-lin.cambridge.arm.com> References: <20190828163636.12967-1-thierry.reding@gmail.com> <20190828163636.12967-4-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190828163636.12967-4-thierry.reding@gmail.com> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Aug 28, 2019 at 06:36:35PM +0200, Thierry Reding wrote: > From: Thierry Reding > > regulator_get_optional() can fail for a number of reasons besides probe > deferral. It can for example return -ENOMEM if it runs out of memory as > it tries to allocate data structures. Propagating only -EPROBE_DEFER is > problematic because it results in these legitimately fatal errors being > treated as "regulator not specified in DT". > > What we really want is to ignore the optional regulators only if they > have not been specified in DT. regulator_get_optional() returns -ENODEV > in this case, so that's the special case that we need to handle. So we > propagate all errors, except -ENODEV, so that real failures will still > cause the driver to fail probe. > > Cc: Shawn Guo > Signed-off-by: Thierry Reding > --- > drivers/pci/controller/dwc/pcie-histb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c > index 954bc2b74bbc..811b5c6d62ea 100644 > --- a/drivers/pci/controller/dwc/pcie-histb.c > +++ b/drivers/pci/controller/dwc/pcie-histb.c > @@ -340,8 +340,8 @@ static int histb_pcie_probe(struct platform_device *pdev) > > hipcie->vpcie = devm_regulator_get_optional(dev, "vpcie"); > if (IS_ERR(hipcie->vpcie)) { > - if (PTR_ERR(hipcie->vpcie) == -EPROBE_DEFER) > - return -EPROBE_DEFER; > + if (PTR_ERR(hipcie->vpcie) != -ENODEV) > + return PTR_ERR(hipcie->vpcie); Once you've applied Bjorn's feedback you can add: Reviewed-by: Andrew Murray > hipcie->vpcie = NULL; > } > > -- > 2.22.0 >