From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E94D2C47404 for ; Thu, 12 Sep 2019 12:59:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA7F3208C2 for ; Thu, 12 Sep 2019 12:59:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731775AbfILM7n (ORCPT ); Thu, 12 Sep 2019 08:59:43 -0400 Received: from foss.arm.com ([217.140.110.172]:33832 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730454AbfILM7m (ORCPT ); Thu, 12 Sep 2019 08:59:42 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 48B7B28; Thu, 12 Sep 2019 05:59:42 -0700 (PDT) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B4FCE3F71F; Thu, 12 Sep 2019 05:59:41 -0700 (PDT) Date: Thu, 12 Sep 2019 13:59:40 +0100 From: Andrew Murray To: Xiaowei Bao , helgaas@kernel.org Cc: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , Leo Li , "kishon@ti.com" , "lorenzo.pieralisi@arm.com" , "M.h. Lian" , Mingkai Hu , Roy Zang , "jingoohan1@gmail.com" , "gustavo.pimentel@synopsys.com" , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "arnd@arndb.de" , "gregkh@linuxfoundation.org" , "Z.q. Hou" Subject: Re: [PATCH v3 11/11] misc: pci_endpoint_test: Add LS1088a in pci_device_id table Message-ID: <20190912125939.GE9720@e119886-lin.cambridge.arm.com> References: <20190902031716.43195-1-xiaowei.bao@nxp.com> <20190902031716.43195-12-xiaowei.bao@nxp.com> <20190902125454.GK9720@e119886-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Sep 03, 2019 at 01:52:30AM +0000, Xiaowei Bao wrote: > > > > -----Original Message----- > > From: Andrew Murray > > Sent: 2019年9月2日 20:55 > > To: Xiaowei Bao > > Cc: robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org; Leo > > Li ; kishon@ti.com; lorenzo.pieralisi@arm.com; M.h. > > Lian ; Mingkai Hu ; Roy > > Zang ; jingoohan1@gmail.com; > > gustavo.pimentel@synopsys.com; linux-pci@vger.kernel.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > linux-arm-kernel@lists.infradead.org; linuxppc-dev@lists.ozlabs.org; > > arnd@arndb.de; gregkh@linuxfoundation.org; Z.q. Hou > > > > Subject: Re: [PATCH v3 11/11] misc: pci_endpoint_test: Add LS1088a in > > pci_device_id table > > > > On Mon, Sep 02, 2019 at 11:17:16AM +0800, Xiaowei Bao wrote: > > > Add LS1088a in pci_device_id table so that pci-epf-test can be used > > > for testing PCIe EP in LS1088a. > > > > > > Signed-off-by: Xiaowei Bao > > > --- > > > v2: > > > - No change. > > > v3: > > > - No change. > > > > > > drivers/misc/pci_endpoint_test.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/misc/pci_endpoint_test.c > > > b/drivers/misc/pci_endpoint_test.c > > > index 6e208a0..d531951 100644 > > > --- a/drivers/misc/pci_endpoint_test.c > > > +++ b/drivers/misc/pci_endpoint_test.c > > > @@ -793,6 +793,7 @@ static const struct pci_device_id > > pci_endpoint_test_tbl[] = { > > > { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) }, > > > { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) }, > > > { PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, 0x81c0) }, > > > + { PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, 0x80c0) }, > > > > The Freescale PCI devices are the only devices in this table that don't have a > > define for their device ID. I think a define should be created for both of the > > device IDs above. > > OK, but I only define in this file, I am not sure this can define in include/linux/pci_ids.h > file This file seems a little inconsistent... - Two of the TI device IDs are defined in pci_ids.h and only used in pci_endpoint_test.c - One of the TI device IDs are defined in pci_endpoint_test.c and only used there - The Freescale device ID is hardcoded and only used in pci_endpoint_test.c The header in pci_ids.h has a comment suggestion definitions are only added where used in multiple files - yet I don't think this holds true. Bjorn - do you have a suggestion? Thanks, Andrew Murray > > Thanks > Xiaowei > > > > > Thanks, > > > > Andrew Murray > > > > > { PCI_DEVICE_DATA(SYNOPSYS, EDDA, NULL) }, > > > { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_AM654), > > > .driver_data = (kernel_ulong_t)&am654_data > > > -- > > > 2.9.5 > > >