Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jonathan Chocron <jonnyc@amazon.com>, bhelgaas@google.com
Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
	robh+dt@kernel.org, mark.rutland@arm.com, andrew.murray@arm.com,
	dwmw@amazon.co.uk, benh@kernel.crashing.org, alisaidi@amazon.com,
	ronenk@amazon.com, barakw@amazon.com, talel@amazon.com,
	hanochu@amazon.com, hhhawa@amazon.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 4/7] PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port
Date: Fri, 13 Sep 2019 12:28:41 +0100
Message-ID: <20190913112841.GA8153@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190912130042.14597-5-jonnyc@amazon.com>

On Thu, Sep 12, 2019 at 04:00:42PM +0300, Jonathan Chocron wrote:
> The Root Port (identified by [1c36:0031]) doesn't support MSI-X. On some
> platforms it is configured to not advertise the capability at all, while
> on others it (mistakenly) does. This causes a panic during
> initialization by the pcieport driver, since it tries to configure the
> MSI-X capability. Specifically, when trying to access the MSI-X table
> a "non-existing addr" exception occurs.
> 
> Example stacktrace snippet:
> 
>   SError Interrupt on CPU2, code 0xbf000000 -- SError
>   CPU: 2 PID: 1 Comm: swapper/0 Not tainted 5.2.0-rc1-Jonny-14847-ge76f1d4a1828-dirty #33
>   Hardware name: Annapurna Labs Alpine V3 EVP (DT)
>   pstate: 80000005 (Nzcv daif -PAN -UAO)
>   pc : __pci_enable_msix_range+0x4e4/0x608
>   lr : __pci_enable_msix_range+0x498/0x608
>   sp : ffffff80117db700
>   x29: ffffff80117db700 x28: 0000000000000001
>   x27: 0000000000000001 x26: 0000000000000000
>   x25: ffffffd3e9d8c0b0 x24: 0000000000000000
>   x23: 0000000000000000 x22: 0000000000000000
>   x21: 0000000000000001 x20: 0000000000000000
>   x19: ffffffd3e9d8c000 x18: ffffffffffffffff
>   x17: 0000000000000000 x16: 0000000000000000
>   x15: ffffff80116496c8 x14: ffffffd3e9844503
>   x13: ffffffd3e9844502 x12: 0000000000000038
>   x11: ffffffffffffff00 x10: 0000000000000040
>   x9 : ffffff801165e270 x8 : ffffff801165e268
>   x7 : 0000000000000002 x6 : 00000000000000b2
>   x5 : ffffffd3e9d8c2c0 x4 : 0000000000000000
>   x3 : 0000000000000000 x2 : 0000000000000000
>   x1 : 0000000000000000 x0 : ffffffd3e9844680
>   Kernel panic - not syncing: Asynchronous SError Interrupt
>   CPU: 2 PID: 1 Comm: swapper/0 Not tainted 5.2.0-rc1-Jonny-14847-ge76f1d4a1828-dirty #33
>   Hardware name: Annapurna Labs Alpine V3 EVP (DT)
>   Call trace:
>    dump_backtrace+0x0/0x140
>    show_stack+0x14/0x20
>    dump_stack+0xa8/0xcc
>    panic+0x140/0x334
>    nmi_panic+0x6c/0x70
>    arm64_serror_panic+0x74/0x88
>    __pte_error+0x0/0x28
>    el1_error+0x84/0xf8
>    __pci_enable_msix_range+0x4e4/0x608
>    pci_alloc_irq_vectors_affinity+0xdc/0x150
>    pcie_port_device_register+0x2b8/0x4e0
>    pcie_portdrv_probe+0x34/0xf0
> 
> Notice that this quirk also disables MSI (which may work, but hasn't
> been tested nor has a current use case), since currently there is no
> standard way to disable only MSI-X.
> 
> Signed-off-by: Jonathan Chocron <jonnyc@amazon.com>
> Reviewed-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> Reviewed-by: Andrew Murray <andrew.murray@arm.com>
> ---
>  drivers/pci/quirks.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

I will prepare this series for upstream but I would like to have Bjorn's
ACK before pushing it out since you updated this patch following his
review.

Thanks,
Lorenzo

> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 2e983f2a0ee9..c1077e806291 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2977,6 +2977,24 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATTANSIC, 0x10a1,
>  			quirk_msi_intx_disable_qca_bug);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATTANSIC, 0xe091,
>  			quirk_msi_intx_disable_qca_bug);
> +
> +/*
> + * Amazon's Annapurna Labs 1c36:0031 Root Ports don't support MSI-X, so it
> + * should be disabled on platforms where the device (mistakenly) advertises it.
> + *
> + * Notice that this quirk also disables MSI (which may work, but hasn't been
> + * tested), since currently there is no standard way to disable only MSI-X.
> + *
> + * The 0031 device id is reused for other non Root Port device types,
> + * therefore the quirk is registered for the PCI_CLASS_BRIDGE_PCI class.
> + */
> +static void quirk_al_msi_disable(struct pci_dev *dev)
> +{
> +	dev->no_msi = 1;
> +	pci_warn(dev, "Disabling MSI/MSI-X\n");
> +}
> +DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031,
> +			      PCI_CLASS_BRIDGE_PCI, 8, quirk_al_msi_disable);
>  #endif /* CONFIG_PCI_MSI */
>  
>  /*
> -- 
> 2.17.1
> 

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 13:00 [PATCH v6 0/7] Amazon's Annapurna Labs DT-based PCIe host controller driver Jonathan Chocron
2019-09-12 13:00 ` [PATCH v6 1/7] PCI: Add Amazon's Annapurna Labs vendor ID Jonathan Chocron
2019-09-12 13:00 ` [PATCH v6 2/7] PCI: Add ACS quirk for Amazon Annapurna Labs root ports Jonathan Chocron
2019-09-12 13:00 ` [PATCH v6 3/7] PCI/VPD: Prevent VPD access for Amazon's Annapurna Labs Root Port Jonathan Chocron
2019-09-12 13:00 ` [PATCH v6 4/7] PCI: Add quirk to disable MSI-X support " Jonathan Chocron
2019-09-13 11:28   ` Lorenzo Pieralisi [this message]
2019-09-12 13:02 ` [PATCH v6 5/7] dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding Jonathan Chocron
2019-09-12 13:02 ` [PATCH v6 6/7] PCI: dwc: al: Add Amazon Annapurna Labs PCIe controller driver Jonathan Chocron
2019-09-12 13:02 ` [PATCH v6 7/7] PCI: dwc: Add validation that PCIe core is set to correct mode Jonathan Chocron

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190913112841.GA8153@e121166-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=alisaidi@amazon.com \
    --cc=andrew.murray@arm.com \
    --cc=barakw@amazon.com \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw@amazon.co.uk \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=hanochu@amazon.com \
    --cc=hhhawa@amazon.com \
    --cc=jingoohan1@gmail.com \
    --cc=jonnyc@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=ronenk@amazon.com \
    --cc=talel@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org linux-pci@archiver.kernel.org
	public-inbox-index linux-pci


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox