From: Bjorn Helgaas <helgaas@kernel.org>
To: Megha Dey <megha.dey@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
linux-pci@vger.kernel.org, maz@kernel.org, rafael@kernel.org,
gregkh@linuxfoundation.org, tglx@linutronix.de, hpa@zytor.com,
alex.williamson@redhat.com, jgg@mellanox.com,
ashok.raj@intel.com, megha.dey@intel.com,
jacob.jun.pan@intel.com,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Sanjay Kumar <sanjay.k.kumar@intel.com>
Subject: Re: [RFC V1 7/7] ims: Add the set_desc callback
Date: Thu, 26 Sep 2019 16:47:46 -0500 [thread overview]
Message-ID: <20190926214746.GA197766@google.com> (raw)
In-Reply-To: <1568338328-22458-8-git-send-email-megha.dey@linux.intel.com>
On Thu, Sep 12, 2019 at 06:32:08PM -0700, Megha Dey wrote:
> Add the set_desc callback to the ims domain ops.
Elsewhere you capitalize "IMS" when it's an initialism.
Generally you capitalized "IRQ" and "MSI" in similar situations, but
there are a couple exceptions (in other commit logs).
> The set_desc callback is used to find a unique hwirq number from a given
> domain.
>
> Each mdev can have a maximum of 2048 IMS interrupts.
Maybe you could mention where this limit comes from and whether it's
related to any #define in these patches?
next prev parent reply other threads:[~2019-09-26 21:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 1:32 [RFC V1 0/7] Add support for a new IMS interrupt mechanism Megha Dey
2019-09-13 1:32 ` [RFC V1 1/7] genirq/msi: Differentiate between various MSI based interrupts Megha Dey
2019-09-13 4:40 ` Greg KH
2019-09-13 14:40 ` Jason Gunthorpe
2019-09-26 21:50 ` Bjorn Helgaas
2019-09-13 1:32 ` [RFC V1 2/7] drivers/base: Introduce callbacks for IMS interrupt domain Megha Dey
2019-09-13 4:39 ` Greg KH
2019-09-13 14:50 ` Jason Gunthorpe
2019-09-13 1:32 ` [RFC V1 3/7] x86/ims: Add support for a new IMS irq domain Megha Dey
2019-09-13 14:52 ` Jason Gunthorpe
2019-09-13 22:07 ` Alex Williamson
2019-09-13 1:32 ` [RFC V1 4/7] irq_remapping: New interfaces to support IMS irqdomain Megha Dey
2019-09-13 1:32 ` [RFC V1 5/7] x86/ims: Introduce x86_ims_ops Megha Dey
2019-09-13 14:54 ` Jason Gunthorpe
2019-09-13 1:32 ` [RFC V1 6/7] ims-msi: Add APIs to allocate/free IMS interrupts Megha Dey
2019-09-26 21:44 ` Bjorn Helgaas
2019-09-13 1:32 ` [RFC V1 7/7] ims: Add the set_desc callback Megha Dey
2019-09-26 21:47 ` Bjorn Helgaas [this message]
2019-09-13 19:50 ` [RFC V1 0/7] Add support for a new IMS interrupt mechanism Jason Gunthorpe
2019-09-13 20:27 ` Raj, Ashok
2019-09-19 18:25 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926214746.GA197766@google.com \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jgg@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maz@kernel.org \
--cc=megha.dey@intel.com \
--cc=megha.dey@linux.intel.com \
--cc=rafael@kernel.org \
--cc=sanjay.k.kumar@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).