From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 726E0C4360C for ; Fri, 27 Sep 2019 13:00:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3173821850 for ; Fri, 27 Sep 2019 13:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569589229; bh=ZRR5GpkwR6Aa/fDKrENAmahjuJ9MmYU6dJrGLK0V3IM=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=tTjrJqHTtOJpLnkQCHc4qZL1ESWg0ie7NsP2h1UkLzJGPQoYjdxMjsPNoIvtg9KzN n+VjPiZNo7vy5Qkk+Fc8Lc8PuwWZ/OYKUvT2KSoAaYRyebxksdTBeewCRXJqcQY/tw 9zvsJbZOPtzteZJ10X6xKLFUEOH1vN+U/V1CyH7w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727195AbfI0NA2 (ORCPT ); Fri, 27 Sep 2019 09:00:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:60568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727076AbfI0NA2 (ORCPT ); Fri, 27 Sep 2019 09:00:28 -0400 Received: from localhost (173-25-179-30.client.mchsi.com [173.25.179.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1986217D9; Fri, 27 Sep 2019 13:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569589227; bh=ZRR5GpkwR6Aa/fDKrENAmahjuJ9MmYU6dJrGLK0V3IM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=KLGDBjTbXzad8oglmmKMJkBY3QdwZGNWEqTeYBha0ElHoxMTT2hrgqjCgjoXZxZNm 9OEB/HIJx2kyrPpqOTpDvWxP/FHkmbzA5zVt3lgky1adf7UXlzw+kdURO8B0TeJqAo 4q3SUtGL9Ed/I+iD/QrosE2eIpzuZ9UbjCd+0zPQ= Date: Fri, 27 Sep 2019 08:00:26 -0500 From: Bjorn Helgaas To: tiantao6 Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH] PCI: vc: fix warning: no previous prototype Message-ID: <20190927130026.GA40841@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1568205651-60209-1-git-send-email-tiantao6@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Sep 11, 2019 at 08:40:51PM +0800, tiantao6 wrote: > From: tiantao > > drivers/pci/vc.c:351:5: warning: no previous prototype for > pci_save_vc_state [-Wmissing-prototypes] > int pci_save_vc_state(struct pci_dev *dev) > > drivers/pci/vc.c:388:6: warning: no previous prototype for > pci_restore_vc_state [-Wmissing-prototypes] > void pci_restore_vc_state(struct pci_dev *dev) > > drivers/pci/vc.c:412:6: warning: no previous prototype for > pci_allocate_vc_save_buffers [-Wmissing-prototypes] > void pci_allocate_vc_save_buffers(struct pci_dev *dev) > > Signed-off-by: Tian Tao Thanks, this was fixed incidentally by ca78410403dd ("PCI: Get rid of dev->has_secondary_link flag"). > --- > drivers/pci/vc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c > index b39e854..111f6d3 100644 > --- a/drivers/pci/vc.c > +++ b/drivers/pci/vc.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include "pci.h" > > /** > * pci_vc_save_restore_dwords - Save or restore a series of dwords > -- > 2.7.4 >