From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F2E7C10F14 for ; Thu, 3 Oct 2019 03:33:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FC34222C3 for ; Thu, 3 Oct 2019 03:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbfJCDdz (ORCPT ); Wed, 2 Oct 2019 23:33:55 -0400 Received: from bmailout2.hostsharing.net ([83.223.78.240]:49331 "EHLO bmailout2.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbfJCDdz (ORCPT ); Wed, 2 Oct 2019 23:33:55 -0400 Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id A3F072802D270; Thu, 3 Oct 2019 05:33:52 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 5C045351CB; Thu, 3 Oct 2019 05:33:52 +0200 (CEST) Date: Thu, 3 Oct 2019 05:33:52 +0200 From: Lukas Wunner To: "Alex G." Cc: Stuart Hayes , Bjorn Helgaas , Austin Bolen , keith.busch@intel.com, "Rafael J . Wysocki" , Mika Westerberg , Andy Shevchenko , "Gustavo A . R . Silva" , Sinan Kaya , Oza Pawandeep , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] PCI: pciehp: Do not turn off slot if presence comes up after link Message-ID: <20191003033352.d5ywkrskpkhafvc4@wunner.de> References: <20191001211419.11245-1-stuart.w.hayes@gmail.com> <20191002041315.6dpqpis5zikosyyc@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Oct 02, 2019 at 05:13:58PM -0500, Alex G. wrote: > On 10/1/19 11:13 PM, Lukas Wunner wrote: > > On Tue, Oct 01, 2019 at 05:14:16PM -0400, Stuart Hayes wrote: > > > This patch set is based on a patch set [1] submitted many months ago by > > > Alexandru Gagniuc, who is no longer working on it. > > > > I'm not sure if it's appropriate to change the author and > > omit Alex' Signed-off-by. > > Legally Dell owns the patches. I have no objection on my end. >From a kernel community POV, I don't think it matters (in this case) who legally owns the copyright to the contributed code. It's just that we go to great lengths to provide proper attribution even for small contributions (e.g. Tested-by). The benefit to the community is that we know who to cc if that portion of the code is changed again and someone knowledgable should take a look. The benefit to contributors is that they can change jobs and their past contributions are still visible in the git history and attributed to their names. By contrast, if you've worked on closed source code and changed jobs, that work isn't visible to future employers or even yourself, and it may happen that someone else takes credit for your past work without you even knowing about it or being able to stop that. (I've seen it before.) In this case, there should be a S-o-b line for Alex preceding that for Stuart, and the author of the commit should be Alex unless a significant portion of the patch was changed. Thanks, Lukas