From: Andrew Murray <andrew.murray@arm.com>
To: Yurii Monakov <monakov.y@gmail.com>
Cc: linux-pci@vger.kernel.org, m-karicheri2@ti.com
Subject: Re: [PATCH] PCI: keystone: Fix outbound region mapping
Date: Fri, 4 Oct 2019 17:05:20 +0100 [thread overview]
Message-ID: <20191004160519.GV42880@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191004154811.GA31397@monakov-y.office.kontur-niirs.ru>
On Fri, Oct 04, 2019 at 06:48:11PM +0300, Yurii Monakov wrote:
> PCIe window memory start address should be incremented by OB_WIN_SIZE
> megabytes (8 MB) instead of plain OB_WIN_SIZE (8).
>
> Signed-off-by: Yurii Monakov <monakov.y@gmail.com>
> ---
> drivers/pci/controller/dwc/pci-keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
> index af677254a072..f19de60ac991 100644
> --- a/drivers/pci/controller/dwc/pci-keystone.c
> +++ b/drivers/pci/controller/dwc/pci-keystone.c
> @@ -422,7 +422,7 @@ static void ks_pcie_setup_rc_app_regs(struct keystone_pcie *ks_pcie)
> lower_32_bits(start) | OB_ENABLEN);
> ks_pcie_app_writel(ks_pcie, OB_OFFSET_HI(i),
> upper_32_bits(start));
> - start += OB_WIN_SIZE;
> + start += OB_WIN_SIZE * SZ_1M;
This looks fine, however are the earlier lines still correct?
val = ilog2(OB_WIN_SIZE);
ks_pcie_app_writel(ks_pcie, OB_SIZE, val);
Thanks,
Andrew Murray
> }
>
> val = ks_pcie_app_readl(ks_pcie, CMD_STATUS);
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-10-04 16:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 15:48 [PATCH] PCI: keystone: Fix outbound region mapping Yurii Monakov
2019-10-04 16:05 ` Andrew Murray [this message]
2019-10-04 16:37 ` Yurii Monakov
2019-12-16 12:03 ` Andrew Murray
2019-12-17 14:31 ` Bjorn Helgaas
2019-12-17 16:31 ` Yurii Monakov
2019-12-17 21:54 ` Bjorn Helgaas
2019-12-18 13:31 ` Yurii Monakov
2019-12-19 11:21 ` Kishon Vijay Abraham I
2020-01-10 17:33 ` Lorenzo Pieralisi
-- strict thread matches above, loose matches on Subject: below --
2019-10-04 15:16 Yurii Monakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004160519.GV42880@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=monakov.y@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).