From: Andrew Murray <andrew.murray@arm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 4/5] PCI: Remove PCIe Kconfig dependencies on PCI
Date: Thu, 7 Nov 2019 09:29:43 +0000 [thread overview]
Message-ID: <20191107092943.GS9723@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191106222420.10216-5-helgaas@kernel.org>
On Wed, Nov 06, 2019 at 04:24:20PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> drivers/pci/pcie/Kconfig is only sourced by drivers/pci/Kconfig, and only
> when PCI is defined, so there's no need to depend on PCI again. Remove the
> unnecessary dependencies.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/pci/pcie/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index b196ad816129..207dac2fd588 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -4,7 +4,6 @@
> #
> config PCIEPORTBUS
> bool "PCI Express Port Bus support"
> - depends on PCI
> help
> This enables PCI Express Port Bus support. Users can then enable
> support for Native Hot-Plug, Advanced Error Reporting, Power
> @@ -63,7 +62,6 @@ config PCIE_ECRC
> #
> config PCIEASPM
> bool "PCI Express ASPM control" if EXPERT
> - depends on PCI
> default y
> help
> This enables OS control over PCI Express ASPM (Active State
Reviewed-by: Andrew Murray <andrew.murray@arm.com>
> --
> 2.24.0.rc1.363.gb1bccd3e3d-goog
>
next prev parent reply other threads:[~2019-11-07 9:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 22:24 [PATCH 0/5] PCI: Clean up PTM message and Kconfig/Makefile nits Bjorn Helgaas
2019-11-06 22:24 ` [PATCH 1/5] PCI/PTM: Remove spurious "d" from granularity message Bjorn Helgaas
2019-11-07 9:28 ` Andrew Murray
2019-11-06 22:24 ` [PATCH 2/5] PCI/PTM: Remove dependency on PCIEPORTBUS Bjorn Helgaas
2019-11-07 9:29 ` Andrew Murray
2019-11-06 22:24 ` [PATCH 3/5] PCI/ASPM: " Bjorn Helgaas
2019-11-07 9:29 ` Andrew Murray
2019-11-06 22:24 ` [PATCH 4/5] PCI: Remove PCIe Kconfig dependencies on PCI Bjorn Helgaas
2019-11-07 9:29 ` Andrew Murray [this message]
2019-11-06 22:24 ` [PATCH 5/5] PCI: Allow building PCIe things without PCIEPORTBUS Bjorn Helgaas
2019-11-07 9:41 ` Andrew Murray
2019-11-07 22:44 ` [PATCH 0/5] PCI: Clean up PTM message and Kconfig/Makefile nits Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107092943.GS9723@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).