From: Bjorn Helgaas <helgaas@kernel.org>
To: Wei Liu <wei.liu@kernel.org>
Cc: linux-pci@vger.kernel.org, rjui@broadcom.com
Subject: Re: [PATCH] PCI: build Broadcom PAXC quirks unconditionally
Date: Tue, 3 Dec 2019 08:42:26 -0600 [thread overview]
Message-ID: <20191203144226.GA255690@google.com> (raw)
In-Reply-To: <CAHd7Wqw56pPXFgvk+vNnrMCeVow6Op2mXONiqHs4C9NrMfS=VQ@mail.gmail.com>
On Tue, Dec 03, 2019 at 02:06:57PM +0000, Wei Liu wrote:
> On Wed, 27 Nov 2019 at 10:59, Wei Liu <wei.liu@kernel.org> wrote:
> >
> > On Tue, 26 Nov 2019 at 23:05, Bjorn Helgaas <helgaas@kernel.org> wrote:
> > >
> > > On Fri, Nov 15, 2019 at 01:58:42PM +0000, Wei Liu wrote:
> > > > CONFIG_PCIE_IPROC_PLATFORM only gets defined when the driver is built
> > > > in. Removing the ifdef will allow us to build the driver as a module.
> > > >
> > > > Signed-off-by: Wei Liu <wei.liu@kernel.org>
> > >
> > > Sorry, I missed this thinking it would be under drivers/pci/controller
> > > and hence handled by Lorenzo.
> > >
> > > So I guess this doesn't fix a build problem, but without this patch,
> > > we just don't run the quirk if the driver is a module, right?
> >
> > Yes, this is correct.
> >
> > Without this patch, the quirk doesn't get to run if the driver is a module.
>
> Are you satisfied with the patch? What do I need to do to get it merged?
You needn't do anything. I'll clarify the changelog (the patch
doesn't actually *enable* building the driver as a module; it merely
ensures that we include the quirk in that case).
This is too late for v5.5, so it will get merged for v5.6 unless the
modular driver itself was enabled for v5.5.
Bjorn
next prev parent reply other threads:[~2019-12-03 14:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 13:58 [PATCH] PCI: build Broadcom PAXC quirks unconditionally Wei Liu
2019-11-25 14:55 ` Wei Liu
2019-11-25 17:39 ` Ray Jui
2019-11-25 17:39 ` Ray Jui
2019-11-26 23:05 ` Bjorn Helgaas
2019-11-27 10:59 ` Wei Liu
2019-12-03 14:06 ` Wei Liu
2019-12-03 14:42 ` Bjorn Helgaas [this message]
2019-12-03 14:46 ` Wei Liu
2019-12-11 0:09 ` Bjorn Helgaas
2019-12-11 0:28 ` Ray Jui
2019-12-11 0:34 ` Bjorn Helgaas
2019-12-11 0:42 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203144226.GA255690@google.com \
--to=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).