From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A850CC2D0C9 for ; Fri, 13 Dec 2019 21:06:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E458F2467A for ; Fri, 13 Dec 2019 21:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576271199; bh=TLRFub19ZhaITE7YjcFkEHRBA0pszoIN5RnRY1gDYLs=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=l9ZKN1Do2lCK/OaxpCTxRrIG41QeJvV1RcA57QpfUBIGew6VMSx+Rj7nT09Zmhlgs gHPwayORQnBydN3qLi6kqZadq8aNWtX9LiYlsqezseDsznaXC88ZdTOvtSjR1hXfFX EoecxTUGQsfj0go6SWsoDQRgYoJd/4GRrY0LypyM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726813AbfLMVGe (ORCPT ); Fri, 13 Dec 2019 16:06:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:45758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbfLMVGe (ORCPT ); Fri, 13 Dec 2019 16:06:34 -0500 Received: from localhost (mobile-166-170-223-177.mycingular.net [166.170.223.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D28C62467A; Fri, 13 Dec 2019 21:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576271193; bh=TLRFub19ZhaITE7YjcFkEHRBA0pszoIN5RnRY1gDYLs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=E/BnZTX+a8LiIkE6EdBlArJFLe2i3cC9dAJ9uaJzsx+hIy4Neio9I5tQwh+XcB08d YZV1mMNvJ1mDG0o5Vz+DTW3Xm51ca/KJWDwKJavT60c/lw5iWIrjQWfoEI7HKwPIq7 9Ynq21FilKYcUtvUrWHTkFAx9x5ELRCpRpV7Bpkg= Date: Fri, 13 Dec 2019 15:06:31 -0600 From: Bjorn Helgaas To: Lad Prabhakar Cc: Rob Herring , Mark Rutland , Geert Uytterhoeven , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , linux-pci@vger.kernel.org, Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Frank Rowand , Gustavo Pimentel , Jingoo Han , Simon Horman , Shawn Lin , Tom Joseph , Heiko Stuebner , linux-rockchip@lists.infradead.org, "Lad, Prabhakar" Subject: Re: [v2 1/6] pci: pcie-rcar: preparation for adding endpoint support Message-ID: <20191213185011.GA170447@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191213084748.11210-2-prabhakar.mahadev-lad.rj@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Dec 13, 2019 at 08:47:43AM +0000, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch prepares for adding endpoint support to rcar controller, > there are no functional changes with this patch, a common file is > created so that it can be shared with endpoint driver. Alongside > this patch fixes checkpatch reported issues. Can you please split this into: - a patch that moves code only, with no other changes except any necessary Kconfig and Makefile changes - another patch that fixes the checkpatch things When the checkpatch fixes are buried in the code move, it's impossible to review them. > Signed-off-by: Lad, Prabhakar > --- > arch/arm64/configs/defconfig | 2 +- > drivers/pci/controller/Kconfig | 4 +- > drivers/pci/controller/Makefile | 2 +- > drivers/pci/controller/pcie-rcar-host.c | 1056 ++++++++++++++++++++++++++ > drivers/pci/controller/pcie-rcar.c | 1229 ++----------------------------- > drivers/pci/controller/pcie-rcar.h | 129 ++++ > 6 files changed, 1242 insertions(+), 1180 deletions(-) > create mode 100644 drivers/pci/controller/pcie-rcar-host.c > create mode 100644 drivers/pci/controller/pcie-rcar.h