From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Yurii Monakov <monakov.y@gmail.com>
Cc: linux-pci@vger.kernel.org, stable@vger.kernel.org,
andrew.murray@arm.com, m-karicheri2@ti.com
Subject: Re: [PATCH v2] PCI: keystone: Fix link training retries initiation
Date: Fri, 10 Jan 2020 17:31:28 +0000 [thread overview]
Message-ID: <20200110173128.GB885@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191217143836.3449cfe2@monakov-y.xu>
On Tue, Dec 17, 2019 at 02:38:36PM +0300, Yurii Monakov wrote:
> ks_pcie_stop_link() function does not clear LTSSM_EN_VAL bit so
> link training was not triggered more than once after startup.
> In configurations where link can be unstable during early boot,
> for example, under low temperature, it will never be established.
>
> Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver")
> Signed-off-by: Yurii Monakov <monakov.y@gmail.com>
> CC:stable@vger.kernel.org
> ---
> drivers/pci/controller/dwc/pci-keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/keystone, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
> index af677254a072..d4de4f6cff8b 100644
> --- a/drivers/pci/controller/dwc/pci-keystone.c
> +++ b/drivers/pci/controller/dwc/pci-keystone.c
> @@ -510,7 +510,7 @@ static void ks_pcie_stop_link(struct dw_pcie *pci)
> /* Disable Link training */
> val = ks_pcie_app_readl(ks_pcie, CMD_STATUS);
> val &= ~LTSSM_EN_VAL;
> - ks_pcie_app_writel(ks_pcie, CMD_STATUS, LTSSM_EN_VAL | val);
> + ks_pcie_app_writel(ks_pcie, CMD_STATUS, val);
> }
>
> static int ks_pcie_start_link(struct dw_pcie *pci)
> --
> 2.17.1
prev parent reply other threads:[~2020-01-10 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 11:38 [PATCH v2] PCI: keystone: Fix link training retries initiation Yurii Monakov
2019-12-17 11:59 ` Andrew Murray
2020-01-10 17:31 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110173128.GB885@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=andrew.murray@arm.com \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=monakov.y@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).