From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A5CC33CAD for ; Mon, 13 Jan 2020 14:15:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDCD4207E0 for ; Mon, 13 Jan 2020 14:15:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728803AbgAMOPh (ORCPT ); Mon, 13 Jan 2020 09:15:37 -0500 Received: from mga04.intel.com ([192.55.52.120]:37977 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728774AbgAMOPh (ORCPT ); Mon, 13 Jan 2020 09:15:37 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 06:15:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,429,1571727600"; d="scan'208";a="244336798" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 13 Jan 2020 06:15:34 -0800 Received: by lahna (sSMTP sendmail emulation); Mon, 13 Jan 2020 16:15:33 +0200 Date: Mon, 13 Jan 2020 16:15:33 +0200 From: Mika Westerberg To: Nicholas Johnson Cc: "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Bjorn Helgaas , Benjamin Herrenschmidt , Logan Gunthorpe Subject: Re: [PATCH v1 2/3] PCI: Change pci_bus_distribute_available_resources() args to struct resource Message-ID: <20200113141533.GJ2838@lahna.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Jan 06, 2020 at 03:45:52PM +0000, Nicholas Johnson wrote: > Change pci_bus_distribute_available_resources() arguments from > resource_size_t to struct resource to add more information required to > get the alignment correct for bridge windows with alignment >1M. > > We require (size, alignment), instead of just (size) which is what is > currently available. The change from resource_size_t to struct resource > does just that. > > Note that the struct resource arguments are passed by value and not by > reference. We do not want to pass by reference and change the resource > size of the parent bridge window. We only want the size information. > > No functional changes. > > Signed-off-by: Nicholas Johnson Reviewed-by: Mika Westerberg