From: Bjorn Helgaas <helgaas@kernel.org>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ashok.raj@intel.com
Subject: Re: [PATCH v15 4/5] PCI/DPC: Add Error Disconnect Recover (EDR) support
Date: Wed, 26 Feb 2020 16:41:30 -0600 [thread overview]
Message-ID: <20200226224130.GA182745@google.com> (raw)
In-Reply-To: <6cabd520-f974-2c33-4ecb-3cfd2dfb00a4@linux.intel.com>
On Wed, Feb 26, 2020 at 02:11:53PM -0800, Kuppuswamy Sathyanarayanan wrote:
> On 2/26/20 1:32 PM, Bjorn Helgaas wrote:
> > On Wed, Feb 26, 2020 at 10:42:27AM -0800, Kuppuswamy Sathyanarayanan wrote:
> > > On 2/25/20 5:02 PM, Bjorn Helgaas wrote:
> > > > On Thu, Feb 13, 2020 at 10:20:16AM -0800, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> > > > > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> > > > > ...
> >
> > > Yes, we could remove it. But it might need some more changes to
> > > dpc driver functions. I can think of two ways,
> > >
> > > 1. Re-factor the DPC driver not to use dpc_dev structure and just use
> > > pci_dev in their functions implementation. But this might lead to
> > > re-reading following dpc_dev structure members every time we
> > > use it in dpc driver functions.
> > >
> > > (Currently in dpc driver probe they cache the following device parameters )
> > >
> > > 9 u16 cap_pos;
> > > 10 bool rp_extensions;
> > > 11 u8 rp_log_size;
> > > 12 u16 ctl;
> > > 13 u16 cap;
> > I think this is basically what I proposed with the sample patch in my
> > response to your 3/5 patch. But I don't see the ctl/cap part, so
> > maybe I missed something.
> if its costly to carry it in pci_dev, we can always re-read them.
> if its ok to use pci_dev, If you want, I can extend your patch to
> include the cap and ctl.
Ah, I see, you added cap & ctl as part of your series. But I don't
think they're ever used after dpc_probe(), are they? So I don't think
they need to be saved at all.
> > > Yes, ownership should be based on _OSC negotiation. I will add necessary
> > > comments here.
> > Why are we not doing this via _OSC negotiation in this series? It
> > would be much better if we could just do it instead of adding a
> > comment that we *should* do it. Nobody knows more about this than you
> > do, so probably nobody else is going to come along and finish this
> > up :)
> Actually Alex G already proposed a patch to fix it.
>
> https://lkml.org/lkml/2018/11/16/202
>
> But that discussion never reached a conclusion. Since a proper fix
> for it would affect some legacy hardwares which solely relies on
> HEST tables, it did not make everyone happy. So it might take a
> lot to convince all the stake holders to merge such patch. So its
> better not to mix both of these patch sets together.
>
> Once this patch set is done, If Alex G is no longer working on it,
> I can work on it.
OK, great, maybe we can make progress on that later.
next prev parent reply other threads:[~2020-02-26 22:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 18:20 [PATCH v15 0/5] Add Error Disconnect Recover (EDR) support sathyanarayanan.kuppuswamy
2020-02-13 18:20 ` [PATCH v15 1/5] PCI/ERR: Update error status after reset_link() sathyanarayanan.kuppuswamy
2020-02-26 13:41 ` Bjorn Helgaas
2020-02-13 18:20 ` [PATCH v15 2/5] PCI/DPC: Remove pcie_device reference from dpc_dev structure sathyanarayanan.kuppuswamy
2020-02-26 13:43 ` Bjorn Helgaas
2020-02-13 18:20 ` [PATCH v15 3/5] PCI/EDR: Export AER, DPC and error recovery functions sathyanarayanan.kuppuswamy
2020-02-26 1:02 ` Bjorn Helgaas
2020-02-26 19:30 ` Kuppuswamy Sathyanarayanan
2020-02-26 21:13 ` Bjorn Helgaas
2020-02-26 21:26 ` Kuppuswamy Sathyanarayanan
2020-02-26 21:48 ` Bjorn Helgaas
2020-02-13 18:20 ` [PATCH v15 4/5] PCI/DPC: Add Error Disconnect Recover (EDR) support sathyanarayanan.kuppuswamy
2020-02-26 1:02 ` Bjorn Helgaas
2020-02-26 18:42 ` Kuppuswamy Sathyanarayanan
2020-02-26 21:32 ` Bjorn Helgaas
2020-02-26 22:11 ` Kuppuswamy Sathyanarayanan
2020-02-26 22:41 ` Bjorn Helgaas [this message]
2020-02-13 18:20 ` [PATCH v15 5/5] PCI/ACPI: Enable EDR support sathyanarayanan.kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226224130.GA182745@google.com \
--to=helgaas@kernel.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).