From: Mikel Rychliski <mikel@mikelr.com>
To: amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Matthew Garrett" <matthewgarrett@google.com>,
"Mikel Rychliski" <mikel@mikelr.com>
Subject: [PATCH 3/4] drm/radeon: iounmap unused mapping
Date: Mon, 2 Mar 2020 22:34:56 -0500 [thread overview]
Message-ID: <20200303033457.12180-4-mikel@mikelr.com> (raw)
In-Reply-To: <20200303033457.12180-1-mikel@mikelr.com>
Now that pci_platform_rom creates a new mapping to access the ROM
image, we should remove this mapping after extracting the BIOS.
Signed-off-by: Mikel Rychliski <mikel@mikelr.com>
---
drivers/gpu/drm/radeon/radeon_bios.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
index c3ae4c92a115..712b88d88957 100644
--- a/drivers/gpu/drm/radeon/radeon_bios.c
+++ b/drivers/gpu/drm/radeon/radeon_bios.c
@@ -123,6 +123,7 @@ static bool radeon_read_platform_bios(struct radeon_device *rdev)
return false;
memcpy_fromio(rdev->bios, bios, size);
+ iounmap(bios);
if (size == 0 || rdev->bios[0] != 0x55 || rdev->bios[1] != 0xaa) {
kfree(rdev->bios);
--
2.13.7
next prev parent reply other threads:[~2020-03-03 3:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 3:34 [PATCH 0/4] Fix loading of radeon BIOS from 32-bit EFI Mikel Rychliski
2020-03-03 3:34 ` [PATCH 1/4] drm/radeon: Stop directly referencing iomem Mikel Rychliski
2020-03-03 3:34 ` [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom Mikel Rychliski
2020-03-03 14:38 ` Bjorn Helgaas
2020-03-04 3:20 ` Mikel Rychliski
2020-03-17 14:28 ` Christoph Hellwig
2020-03-03 3:34 ` Mikel Rychliski [this message]
2020-03-17 14:29 ` [PATCH 3/4] drm/radeon: iounmap unused mapping Christoph Hellwig
2020-03-03 3:34 ` [PATCH 4/4] drm/amdgpu: " Mikel Rychliski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303033457.12180-4-mikel@mikelr.com \
--to=mikel@mikelr.com \
--cc=David1.Zhou@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=linux-pci@vger.kernel.org \
--cc=matthewgarrett@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).