From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40A00C3F2CD for ; Wed, 4 Mar 2020 13:44:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1623521739 for ; Wed, 4 Mar 2020 13:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583329487; bh=jdTUtZCeADw4iFzCvLuSOdsEnfJb9E0SIWAQY6oL210=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=NZdRr7q9nCP8P1MUY7MA+g6Zcq5s6g+p4cbqWkLYhm0Ur/9xUoqtLPM/WyjY7orB4 8TM+jKxqTrUtz5uxaprwzrbLlSq9/5lLPv3iHXIet4WspZFC1buIbQ5IyBZZJwJTDU ZmogJbo+FCdnAmO3fszhav4qJS4q2any2HtLRXNE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729398AbgCDNoq (ORCPT ); Wed, 4 Mar 2020 08:44:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:57922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbgCDNoq (ORCPT ); Wed, 4 Mar 2020 08:44:46 -0500 Received: from localhost (173-25-83-245.client.mchsi.com [173.25.83.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E8A52166E; Wed, 4 Mar 2020 13:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583329485; bh=jdTUtZCeADw4iFzCvLuSOdsEnfJb9E0SIWAQY6oL210=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=sty86VgjWMYbLJNmBzBXyiSMF/i3BdVPFIxs11zNEI6cgDn8K87vzpw5fHgdUq+dz +XyL0uG0QmUwVedBDhYOWwShe/8e7SkMsRfEz8dAA6+/+Dd4NfpF0lLLIpIfRXa1U9 DCjV7Kpo3yeFsYZWF2kEQjvt8ATA4sML11v2Ctk8= Date: Wed, 4 Mar 2020 07:44:44 -0600 From: Bjorn Helgaas To: Heiner Kallweit Cc: Realtek linux nic maintainers , David Miller , Mirko Lindner , Stephen Hemminger , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List , "netdev@vger.kernel.org" , alsa-devel@alsa-project.org Subject: Re: [PATCH v4 09/10] PCI: pci-bridge-emul: Use new constant PCI_STATUS_ERROR_BITS Message-ID: <20200304134444.GA198415@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04851614-b906-2b1b-f937-189c3c210880@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat, Feb 29, 2020 at 11:28:18PM +0100, Heiner Kallweit wrote: > Use new constant PCI_STATUS_ERROR_BITS to simplify the code. > > Signed-off-by: Heiner Kallweit Acked-by: Bjorn Helgaas > --- > drivers/pci/pci-bridge-emul.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c > index fffa77093..4f4f54bc7 100644 > --- a/drivers/pci/pci-bridge-emul.c > +++ b/drivers/pci/pci-bridge-emul.c > @@ -50,12 +50,7 @@ static const struct pci_bridge_reg_behavior pci_regs_behavior[] = { > (PCI_STATUS_CAP_LIST | PCI_STATUS_66MHZ | > PCI_STATUS_FAST_BACK | PCI_STATUS_DEVSEL_MASK) << 16), > .rsvd = GENMASK(15, 10) | ((BIT(6) | GENMASK(3, 0)) << 16), > - .w1c = (PCI_STATUS_PARITY | > - PCI_STATUS_SIG_TARGET_ABORT | > - PCI_STATUS_REC_TARGET_ABORT | > - PCI_STATUS_REC_MASTER_ABORT | > - PCI_STATUS_SIG_SYSTEM_ERROR | > - PCI_STATUS_DETECTED_PARITY) << 16, > + .w1c = PCI_STATUS_ERROR_BITS << 16, > }, > [PCI_CLASS_REVISION / 4] = { .ro = ~0 }, > > @@ -100,12 +95,7 @@ static const struct pci_bridge_reg_behavior pci_regs_behavior[] = { > PCI_STATUS_DEVSEL_MASK) << 16) | > GENMASK(11, 8) | GENMASK(3, 0)), > > - .w1c = (PCI_STATUS_PARITY | > - PCI_STATUS_SIG_TARGET_ABORT | > - PCI_STATUS_REC_TARGET_ABORT | > - PCI_STATUS_REC_MASTER_ABORT | > - PCI_STATUS_SIG_SYSTEM_ERROR | > - PCI_STATUS_DETECTED_PARITY) << 16, > + .w1c = PCI_STATUS_ERROR_BITS << 16, > > .rsvd = ((BIT(6) | GENMASK(4, 0)) << 16), > }, > -- > 2.25.1 > >