Re: [PATCH v3 0/3] PCI: hv: Generify pci-hyperv.c

From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Michael Kelley <mikelley@microsoft.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Sasha Levin <sashal@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Andrew Murray <andrew.murray@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v3 0/3] PCI: hv: Generify pci-hyperv.c
Date: Mon, 9 Mar 2020 15:03:28 +0000	[thread overview]
Message-ID: <20200309150319.GA18350@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200309143548.GB118238@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net>

On Mon, Mar 09, 2020 at 10:35:48PM +0800, Boqun Feng wrote:
> Hi Lorenzo,
> 
> On Fri, Feb 21, 2020 at 10:44:54AM +0000, Lorenzo Pieralisi wrote:
> > On Fri, Feb 21, 2020 at 10:33:44AM +0800, Boqun Feng wrote:
> > > Ping ;-)
> > > 
> > > Any suggestion or plan on this patchset?
> > 
> > Hi,
> > 
> > I shall have a look shortly, thanks.
> > 
> 
> Any chance you got some time to look into this?

I did last week and I applied it now, pci/hv for v5.7.

Thanks,
Lorenzo

> Regards,
> Boqun
> 
> > Lorenzo
> > 
> > > Thanks and Regards,
> > > Boqun
> > > 
> > > On Mon, Feb 10, 2020 at 11:39:50AM +0800, Boqun Feng wrote:
> > > > Hi,
> > > > 
> > > > This is the first part for virtual PCI support of Hyper-V guest on
> > > > ARM64. The whole patchset doesn't have any functional change, but only
> > > > refactors the pci-hyperv.c code to make it more arch-independent.
> > > > 
> > > > Previous version:
> > > > v1: https://lore.kernel.org/lkml/20200121015713.69691-1-boqun.feng@gmail.com/
> > > > v2: https://lore.kernel.org/linux-arm-kernel/20200203050313.69247-1-boqun.feng@gmail.com/
> > > > 
> > > > Changes since v2:
> > > > 
> > > > *	Rebased on 5.6-rc1
> > > > 
> > > > *	Reword commit logs as per Andrew's suggestion.
> > > > 
> > > > *	It makes more sense to have a generic interface to set the whole
> > > > 	msi_entry rather than only the "address" field. So change
> > > > 	hv_set_msi_address_from_desc() to hv_set_msi_entry_from_desc().
> > > > 	Additionally, make it an inline function as per the suggestion
> > > > 	of Andrew and Thomas.
> > > > 
> > > > *	Add the missing comment saying the partition_id of
> > > > 	hv_retarget_device_interrupt must be self.
> > > > 
> > > > *	Add the explanation for why "__packed" is needed for TLFS
> > > > 	structures.
> > > > 
> > > > I've done compile and boot test of this patchset, also done some tests
> > > > with a pass-through NVMe device.
> > > > 
> > > > Suggestions and comments are welcome!
> > > > 
> > > > Regards,
> > > > Boqun
> > > > 
> > > > Boqun Feng (3):
> > > >   PCI: hv: Move hypercall related definitions into tlfs header
> > > >   PCI: hv: Move retarget related structures into tlfs header
> > > >   PCI: hv: Introduce hv_msi_entry
> > > > 
> > > >  arch/x86/include/asm/hyperv-tlfs.h  | 41 +++++++++++++++++++++++++++
> > > >  arch/x86/include/asm/mshyperv.h     |  8 ++++++
> > > >  drivers/pci/controller/pci-hyperv.c | 43 ++---------------------------
> > > >  3 files changed, 52 insertions(+), 40 deletions(-)
> > > > 
> > > > -- 
> > > > 2.24.1
> > > > 