archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] PCI: endpoint: Fix clearing start entry in configfs
@ 2020-02-26  5:52 Kunihiko Hayashi
  2020-03-11 11:18 ` Lorenzo Pieralisi
  0 siblings, 1 reply; 2+ messages in thread
From: Kunihiko Hayashi @ 2020-02-26  5:52 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Lorenzo Pieralisi
  Cc: linux-pci, linux-kernel, Kunihiko Hayashi

After endpoint has started using configfs, if 0 is written to the entry
'start', the controller stops but the entry value remains 1.

At this time, unlinking the function from the controller, WARN_ON_ONCE()
in pci_epc_epf_unlink() will be triggered despite right behavior.

This fixes the issue by clearing the entry when stopping the controller.

Fixes: d74679911610 ("PCI: endpoint: Introduce configfs entry for configuring EP functions")
Cc: Kishon Vijay Abraham I <>
Signed-off-by: Kunihiko Hayashi <>
Acked-by: Kishon Vijay Abraham I <>
 drivers/pci/endpoint/pci-ep-cfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
index d1288a0..4fead88 100644
--- a/drivers/pci/endpoint/pci-ep-cfs.c
+++ b/drivers/pci/endpoint/pci-ep-cfs.c
@@ -58,6 +58,7 @@ static ssize_t pci_epc_start_store(struct config_item *item, const char *page,
 	if (!start) {
+		epc_group->start = 0;
 		return len;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-11 11:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26  5:52 [PATCH v2] PCI: endpoint: Fix clearing start entry in configfs Kunihiko Hayashi
2020-03-11 11:18 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).