* [PATCH RESEND] ntb_hw_switchtec: Fix ntb_mw_clear_trans returning error if size == 0
@ 2019-07-10 8:44 Alexander Fomichev
2020-01-22 13:15 ` Alexander Fomichev
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Fomichev @ 2019-07-10 8:44 UTC (permalink / raw)
To: linux-ntb, linux-pci; +Cc: linux, Logan Gunthorpe
ntb_mw_set_trans should work as ntb_mw_clear_trans when size == 0 and/or
addr == 0. But error in xlate_pos checking condition prevents this.
Fix the condition to make ntb_mw_clear_trans working.
Signed-off-by: Alexander Fomichev <fomichev.ru@gmail.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
index 1e2f627d3bac..19d46af19650 100644
--- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
+++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
@@ -299,7 +299,7 @@ static int switchtec_ntb_mw_set_trans(struct ntb_dev *ntb, int pidx, int widx,
if (widx >= switchtec_ntb_mw_count(ntb, pidx))
return -EINVAL;
- if (xlate_pos < 12)
+ if (size != 0 && xlate_pos < 12)
return -EINVAL;
if (!IS_ALIGNED(addr, BIT_ULL(xlate_pos))) {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] ntb_hw_switchtec: Fix ntb_mw_clear_trans returning error if size == 0
2019-07-10 8:44 [PATCH RESEND] ntb_hw_switchtec: Fix ntb_mw_clear_trans returning error if size == 0 Alexander Fomichev
@ 2020-01-22 13:15 ` Alexander Fomichev
2020-03-03 12:32 ` Alexander Fomichev
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Fomichev @ 2020-01-22 13:15 UTC (permalink / raw)
To: linux-ntb, linux-pci; +Cc: linux, Logan Gunthorpe
Somehow this patch was lost. The problem is still actual.
Please, add to upstream.
On Wed, Jul 10, 2019 at 11:44:27AM +0300, Alexander Fomichev wrote:
> ntb_mw_set_trans should work as ntb_mw_clear_trans when size == 0 and/or
> addr == 0. But error in xlate_pos checking condition prevents this.
> Fix the condition to make ntb_mw_clear_trans working.
>
> Signed-off-by: Alexander Fomichev <fomichev.ru@gmail.com>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> ---
> drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> index 1e2f627d3bac..19d46af19650 100644
> --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> @@ -299,7 +299,7 @@ static int switchtec_ntb_mw_set_trans(struct ntb_dev *ntb, int pidx, int widx,
> if (widx >= switchtec_ntb_mw_count(ntb, pidx))
> return -EINVAL;
>
> - if (xlate_pos < 12)
> + if (size != 0 && xlate_pos < 12)
> return -EINVAL;
>
> if (!IS_ALIGNED(addr, BIT_ULL(xlate_pos))) {
> --
> 2.17.1
--
Regards,
Alexander
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] ntb_hw_switchtec: Fix ntb_mw_clear_trans returning error if size == 0
2020-01-22 13:15 ` Alexander Fomichev
@ 2020-03-03 12:32 ` Alexander Fomichev
2020-03-12 23:39 ` Jon Mason
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Fomichev @ 2020-03-03 12:32 UTC (permalink / raw)
To: linux-ntb, linux-pci
Cc: linux, Logan Gunthorpe, Kurt Schwemmer, Jon Mason, Allen Hubbe,
Dave Jiang
Ping?
CC: Jon Mason <jdmason@kudzu.us>
CC: Dave Jiang <dave.jiang@intel.com>
CC: Allen Hubbe <allenbh@gmail.com>
CC: Kurt Schwemmer <kurt.schwemmer@microsemi.com>
CC: Logan Gunthorpe <logang@deltatee.com>
On Wed, Jan 22, 2020 at 04:15:13PM +0300, Alexander Fomichev wrote:
> Somehow this patch was lost. The problem is still actual.
> Please, add to upstream.
>
> On Wed, Jul 10, 2019 at 11:44:27AM +0300, Alexander Fomichev wrote:
> > ntb_mw_set_trans should work as ntb_mw_clear_trans when size == 0 and/or
> > addr == 0. But error in xlate_pos checking condition prevents this.
> > Fix the condition to make ntb_mw_clear_trans working.
> >
> > Signed-off-by: Alexander Fomichev <fomichev.ru@gmail.com>
> > Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> > ---
> > drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > index 1e2f627d3bac..19d46af19650 100644
> > --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > @@ -299,7 +299,7 @@ static int switchtec_ntb_mw_set_trans(struct ntb_dev *ntb, int pidx, int widx,
> > if (widx >= switchtec_ntb_mw_count(ntb, pidx))
> > return -EINVAL;
> >
> > - if (xlate_pos < 12)
> > + if (size != 0 && xlate_pos < 12)
> > return -EINVAL;
> >
> > if (!IS_ALIGNED(addr, BIT_ULL(xlate_pos))) {
> > --
> > 2.17.1
>
> --
> Regards,
> Alexander
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] ntb_hw_switchtec: Fix ntb_mw_clear_trans returning error if size == 0
2020-03-03 12:32 ` Alexander Fomichev
@ 2020-03-12 23:39 ` Jon Mason
2020-03-13 8:17 ` Alexander Fomichev
0 siblings, 1 reply; 5+ messages in thread
From: Jon Mason @ 2020-03-12 23:39 UTC (permalink / raw)
To: Alexander Fomichev
Cc: linux-ntb, linux-pci, linux, Logan Gunthorpe, Kurt Schwemmer,
Allen Hubbe, Dave Jiang
On Tue, Mar 3, 2020 at 7:32 AM Alexander Fomichev <fomichev.ru@gmail.com> wrote:
>
> Ping?
Sorry, I missed this somehow :(
I just pulled it in and it should be in my github tree in the next hour or so.
Thanks,
Jon
>
> CC: Jon Mason <jdmason@kudzu.us>
> CC: Dave Jiang <dave.jiang@intel.com>
> CC: Allen Hubbe <allenbh@gmail.com>
> CC: Kurt Schwemmer <kurt.schwemmer@microsemi.com>
> CC: Logan Gunthorpe <logang@deltatee.com>
>
> On Wed, Jan 22, 2020 at 04:15:13PM +0300, Alexander Fomichev wrote:
> > Somehow this patch was lost. The problem is still actual.
> > Please, add to upstream.
> >
> > On Wed, Jul 10, 2019 at 11:44:27AM +0300, Alexander Fomichev wrote:
> > > ntb_mw_set_trans should work as ntb_mw_clear_trans when size == 0 and/or
> > > addr == 0. But error in xlate_pos checking condition prevents this.
> > > Fix the condition to make ntb_mw_clear_trans working.
> > >
> > > Signed-off-by: Alexander Fomichev <fomichev.ru@gmail.com>
> > > Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> > > ---
> > > drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > > index 1e2f627d3bac..19d46af19650 100644
> > > --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > > +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > > @@ -299,7 +299,7 @@ static int switchtec_ntb_mw_set_trans(struct ntb_dev *ntb, int pidx, int widx,
> > > if (widx >= switchtec_ntb_mw_count(ntb, pidx))
> > > return -EINVAL;
> > >
> > > - if (xlate_pos < 12)
> > > + if (size != 0 && xlate_pos < 12)
> > > return -EINVAL;
> > >
> > > if (!IS_ALIGNED(addr, BIT_ULL(xlate_pos))) {
> > > --
> > > 2.17.1
> >
> > --
> > Regards,
> > Alexander
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] ntb_hw_switchtec: Fix ntb_mw_clear_trans returning error if size == 0
2020-03-12 23:39 ` Jon Mason
@ 2020-03-13 8:17 ` Alexander Fomichev
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Fomichev @ 2020-03-13 8:17 UTC (permalink / raw)
To: Jon Mason
Cc: linux-ntb, linux-pci, linux, Logan Gunthorpe, Kurt Schwemmer,
Allen Hubbe, Dave Jiang
Thank you very much.
Regards,
Alexander.
On Thu, Mar 12, 2020 at 07:39:02PM -0400, Jon Mason wrote:
> On Tue, Mar 3, 2020 at 7:32 AM Alexander Fomichev <fomichev.ru@gmail.com> wrote:
> >
> > Ping?
>
> Sorry, I missed this somehow :(
>
> I just pulled it in and it should be in my github tree in the next hour or so.
>
> Thanks,
> Jon
>
> >
> > CC: Jon Mason <jdmason@kudzu.us>
> > CC: Dave Jiang <dave.jiang@intel.com>
> > CC: Allen Hubbe <allenbh@gmail.com>
> > CC: Kurt Schwemmer <kurt.schwemmer@microsemi.com>
> > CC: Logan Gunthorpe <logang@deltatee.com>
> >
> > On Wed, Jan 22, 2020 at 04:15:13PM +0300, Alexander Fomichev wrote:
> > > Somehow this patch was lost. The problem is still actual.
> > > Please, add to upstream.
> > >
> > > On Wed, Jul 10, 2019 at 11:44:27AM +0300, Alexander Fomichev wrote:
> > > > ntb_mw_set_trans should work as ntb_mw_clear_trans when size == 0 and/or
> > > > addr == 0. But error in xlate_pos checking condition prevents this.
> > > > Fix the condition to make ntb_mw_clear_trans working.
> > > >
> > > > Signed-off-by: Alexander Fomichev <fomichev.ru@gmail.com>
> > > > Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> > > > ---
> > > > drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > > > index 1e2f627d3bac..19d46af19650 100644
> > > > --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > > > +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > > > @@ -299,7 +299,7 @@ static int switchtec_ntb_mw_set_trans(struct ntb_dev *ntb, int pidx, int widx,
> > > > if (widx >= switchtec_ntb_mw_count(ntb, pidx))
> > > > return -EINVAL;
> > > >
> > > > - if (xlate_pos < 12)
> > > > + if (size != 0 && xlate_pos < 12)
> > > > return -EINVAL;
> > > >
> > > > if (!IS_ALIGNED(addr, BIT_ULL(xlate_pos))) {
> > > > --
> > > > 2.17.1
> > >
> > > --
> > > Regards,
> > > Alexander
--
Regards,
Alexander
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-13 8:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-10 8:44 [PATCH RESEND] ntb_hw_switchtec: Fix ntb_mw_clear_trans returning error if size == 0 Alexander Fomichev
2020-01-22 13:15 ` Alexander Fomichev
2020-03-03 12:32 ` Alexander Fomichev
2020-03-12 23:39 ` Jon Mason
2020-03-13 8:17 ` Alexander Fomichev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).