From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
Vidya Sagar <vidyas@nvidia.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: functions/pci-epf-test: Fix compiler error
Date: Tue, 17 Mar 2020 11:17:41 +0000 [thread overview]
Message-ID: <20200317111732.GA25261@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200317074719.10668-1-kishon@ti.com>
On Tue, Mar 17, 2020 at 01:17:19PM +0530, Kishon Vijay Abraham I wrote:
> Commit 812828eb5072 ("PCI: endpoint: Fix ->set_msix() to take BIR
> and offset as arguments") was created before adding deferred
> core initialization support in commit 5e50ee27d4a5 ("PCI: pci-epf-test:
> Add support to defer core initialization").
> However since deferred core initialization was merged before
> re-designing MSI-X support, it caused the following compiler error.
>
> drivers/pci/endpoint/functions/pci-epf-test.c:697:12: error: ‘epf_test’ undeclared (first use in this function);
>
> Fix the compilation error here.
>
> Fixes: 812828eb5072 ("PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> Lorenzo,
>
> This patch can be squashed with
> "PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments"
Done, thank you very much.
Lorenzo
> Thanks
> Kishon
>
> drivers/pci/endpoint/functions/pci-epf-test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index eaf192be02bb..3b4cf7e2bc60 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -660,6 +660,7 @@ static int pci_epf_test_set_bar(struct pci_epf *epf)
>
> static int pci_epf_test_core_init(struct pci_epf *epf)
> {
> + struct pci_epf_test *epf_test = epf_get_drvdata(epf);
> struct pci_epf_header *header = epf->header;
> const struct pci_epc_features *epc_features;
> struct pci_epc *epc = epf->epc;
> --
> 2.17.1
>
prev parent reply other threads:[~2020-03-17 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 7:47 [PATCH] PCI: endpoint: functions/pci-epf-test: Fix compiler error Kishon Vijay Abraham I
2020-03-17 11:17 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317111732.GA25261@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).