From: Christoph Hellwig <hch@infradead.org>
To: Mikel Rychliski <mikel@mikelr.com>
Cc: amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Matthew Garrett" <matthewgarrett@google.com>
Subject: Re: [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom
Date: Tue, 17 Mar 2020 07:28:35 -0700 [thread overview]
Message-ID: <20200317142835.GA23471@infradead.org> (raw)
In-Reply-To: <20200303033457.12180-3-mikel@mikelr.com>
Any reason drivers can't just use pci_map_rom insteadἅ which already
does the right thing?
next prev parent reply other threads:[~2020-03-17 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 3:34 [PATCH 0/4] Fix loading of radeon BIOS from 32-bit EFI Mikel Rychliski
2020-03-03 3:34 ` [PATCH 1/4] drm/radeon: Stop directly referencing iomem Mikel Rychliski
2020-03-03 3:34 ` [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom Mikel Rychliski
2020-03-03 14:38 ` Bjorn Helgaas
2020-03-04 3:20 ` Mikel Rychliski
2020-03-17 14:28 ` Christoph Hellwig [this message]
2020-03-03 3:34 ` [PATCH 3/4] drm/radeon: iounmap unused mapping Mikel Rychliski
2020-03-17 14:29 ` Christoph Hellwig
2020-03-03 3:34 ` [PATCH 4/4] drm/amdgpu: " Mikel Rychliski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317142835.GA23471@infradead.org \
--to=hch@infradead.org \
--cc=David1.Zhou@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=linux-pci@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=mikel@mikelr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).