linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT
@ 2020-03-18  9:33 Zhiqiang Hou
  2020-03-18 10:35 ` Lorenzo Pieralisi
  0 siblings, 1 reply; 4+ messages in thread
From: Zhiqiang Hou @ 2020-03-18  9:33 UTC (permalink / raw)
  To: linux-pci, linux-kernel, lorenzo.pieralisi, amurray, bhelgaas, rdunlap
  Cc: Hou Zhiqiang

From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
into PCIE_MOBIVEIL_PLAT.

WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
  Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
  Selected by [y]:
  - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
 drivers/pci/controller/mobiveil/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
index 7439991ee82c..a62d247018cf 100644
--- a/drivers/pci/controller/mobiveil/Kconfig
+++ b/drivers/pci/controller/mobiveil/Kconfig
@@ -15,6 +15,7 @@ config PCIE_MOBIVEIL_PLAT
 	bool "Mobiveil AXI PCIe controller"
 	depends on ARCH_ZYNQMP || COMPILE_TEST
 	depends on OF
+	depends on PCI_MSI_IRQ_DOMAIN
 	select PCIE_MOBIVEIL_HOST
 	help
 	  Say Y here if you want to enable support for the Mobiveil AXI PCIe
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT
  2020-03-18  9:33 [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT Zhiqiang Hou
@ 2020-03-18 10:35 ` Lorenzo Pieralisi
  2020-03-18 16:27   ` Randy Dunlap
  2020-03-18 16:30   ` Bjorn Helgaas
  0 siblings, 2 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2020-03-18 10:35 UTC (permalink / raw)
  To: Zhiqiang Hou; +Cc: linux-pci, linux-kernel, amurray, bhelgaas, rdunlap

On Wed, Mar 18, 2020 at 05:33:12PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> 
> Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
> into PCIE_MOBIVEIL_PLAT.
> 
> WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
>   Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
>   Selected by [y]:
>   - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]
> 
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
>  drivers/pci/controller/mobiveil/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

I have applied it to pci/mobiveil for v5.7.

Thanks,
Lorenzo

> diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
> index 7439991ee82c..a62d247018cf 100644
> --- a/drivers/pci/controller/mobiveil/Kconfig
> +++ b/drivers/pci/controller/mobiveil/Kconfig
> @@ -15,6 +15,7 @@ config PCIE_MOBIVEIL_PLAT
>  	bool "Mobiveil AXI PCIe controller"
>  	depends on ARCH_ZYNQMP || COMPILE_TEST
>  	depends on OF
> +	depends on PCI_MSI_IRQ_DOMAIN
>  	select PCIE_MOBIVEIL_HOST
>  	help
>  	  Say Y here if you want to enable support for the Mobiveil AXI PCIe
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT
  2020-03-18 10:35 ` Lorenzo Pieralisi
@ 2020-03-18 16:27   ` Randy Dunlap
  2020-03-18 16:30   ` Bjorn Helgaas
  1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-03-18 16:27 UTC (permalink / raw)
  To: Lorenzo Pieralisi, Zhiqiang Hou
  Cc: linux-pci, linux-kernel, amurray, bhelgaas

On 3/18/20 3:35 AM, Lorenzo Pieralisi wrote:
> On Wed, Mar 18, 2020 at 05:33:12PM +0800, Zhiqiang Hou wrote:
>> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>>
>> Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
>> into PCIE_MOBIVEIL_PLAT.
>>
>> WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
>>   Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
>>   Selected by [y]:
>>   - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]
>>
>> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>> ---
>>  drivers/pci/controller/mobiveil/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
> 
> I have applied it to pci/mobiveil for v5.7.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> Thanks,
> Lorenzo
> 
>> diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
>> index 7439991ee82c..a62d247018cf 100644
>> --- a/drivers/pci/controller/mobiveil/Kconfig
>> +++ b/drivers/pci/controller/mobiveil/Kconfig
>> @@ -15,6 +15,7 @@ config PCIE_MOBIVEIL_PLAT
>>  	bool "Mobiveil AXI PCIe controller"
>>  	depends on ARCH_ZYNQMP || COMPILE_TEST
>>  	depends on OF
>> +	depends on PCI_MSI_IRQ_DOMAIN
>>  	select PCIE_MOBIVEIL_HOST
>>  	help
>>  	  Say Y here if you want to enable support for the Mobiveil AXI PCIe
>> -- 
>> 2.17.1
>>


-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT
  2020-03-18 10:35 ` Lorenzo Pieralisi
  2020-03-18 16:27   ` Randy Dunlap
@ 2020-03-18 16:30   ` Bjorn Helgaas
  1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2020-03-18 16:30 UTC (permalink / raw)
  To: Lorenzo Pieralisi; +Cc: Zhiqiang Hou, linux-pci, linux-kernel, amurray, rdunlap

On Wed, Mar 18, 2020 at 10:35:16AM +0000, Lorenzo Pieralisi wrote:
> On Wed, Mar 18, 2020 at 05:33:12PM +0800, Zhiqiang Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > 
> > Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
> > into PCIE_MOBIVEIL_PLAT.
> > 
> > WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
> >   Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
> >   Selected by [y]:
> >   - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]
> > 
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> >  drivers/pci/controller/mobiveil/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> 
> I have applied it to pci/mobiveil for v5.7.

Thanks, I updated my "next" branch with this.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-18 16:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18  9:33 [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT Zhiqiang Hou
2020-03-18 10:35 ` Lorenzo Pieralisi
2020-03-18 16:27   ` Randy Dunlap
2020-03-18 16:30   ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).