From: Bjorn Helgaas <helgaas@kernel.org>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: linux-pci@vger.kernel.org, rajatja@google.com, linuxarm@huawei.com
Subject: Re: [PATCH v2] PCI/ASPM: Fix wrong field set when config L1SS
Date: Wed, 18 Mar 2020 18:06:05 -0500 [thread overview]
Message-ID: <20200318230605.GA1704@google.com> (raw)
In-Reply-To: <1584093227-1292-1-git-send-email-yangyicong@hisilicon.com>
On Fri, Mar 13, 2020 at 05:53:47PM +0800, Yicong Yang wrote:
> We enable proper L1 substates in the end of pcie_config_aspm_l1ss(). It's
> PCI_L1SS_CTL1_L1SS_MASK field should we set in PCI_L1SS_CTL1 register
> rather than PCI_L1SS_CAP_L1_PM_SS.
>
> Fixes: aeda9adebab8 ("PCI/ASPM: Configure L1 substate settings")
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Applied to pci/aspm for v5.7, thanks!
I also added a stable tag for v4.11+.
> ---
> change since v1:
> 1. Add fixes tag in the commit message
> 2. change category to ASPM from PM in the subject
> Link: https://lore.kernel.org/linux-pci/20200312194202.GA162085@google.com/
>
> drivers/pci/pcie/aspm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 0dcd443..c2596e7 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -747,9 +747,9 @@ static void pcie_config_aspm_l1ss(struct pcie_link_state *link, u32 state)
>
> /* Enable what we need to enable */
> pci_clear_and_set_dword(parent, up_cap_ptr + PCI_L1SS_CTL1,
> - PCI_L1SS_CAP_L1_PM_SS, val);
> + PCI_L1SS_CTL1_L1SS_MASK, val);
> pci_clear_and_set_dword(child, dw_cap_ptr + PCI_L1SS_CTL1,
> - PCI_L1SS_CAP_L1_PM_SS, val);
> + PCI_L1SS_CTL1_L1SS_MASK, val);
> }
>
> static void pcie_config_aspm_dev(struct pci_dev *pdev, u32 val)
> --
> 2.8.1
>
prev parent reply other threads:[~2020-03-18 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 9:53 [PATCH v2] PCI/ASPM: Fix wrong field set when config L1SS Yicong Yang
2020-03-18 23:06 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318230605.GA1704@google.com \
--to=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rajatja@google.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).