archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: dwc: fix ERROR: modpost: dw_pcie_ep_*.o undefined
@ 2020-03-19 12:48 Anders Roxell
  0 siblings, 0 replies; only message in thread
From: Anders Roxell @ 2020-03-19 12:48 UTC (permalink / raw)
  To: jingoohan1, gustavo.pimentel, lorenzo.pieralisi, bhelgaas
  Cc: linux-pci, linux-kernel, Anders Roxell

When building the PCIE_TEGRA194 as a module the common parts are
build-in.  That leads us to the following modpost error:

ERROR: modpost: "dw_pcie_ep_init" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
make[2]: *** [../scripts/Makefile.modpost:94: __modpost] Error 1
make[1]: *** [/linux/Makefile:1298: modules] Error 2
make: *** [Makefile:180: sub-make] Error 2
make: Target 'modules' not remade because of errors.

Rework to EXPORT_SYMBOL_GPL for those functions.

Fixes: 5b645b7fade9 ("PCI: tegra: Add support for PCIe endpoint mode in Tegra194")
Signed-off-by: Anders Roxell <>
 drivers/pci/controller/dwc/pcie-designware-ep.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
index 4233c4321373..1cdcbd102ce8 100644
--- a/drivers/pci/controller/dwc/pcie-designware-ep.c
+++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
@@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)
 void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
@@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
 static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar,
 				   int flags)
@@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)
 	return 0;
 int dw_pcie_ep_init(struct dw_pcie_ep *ep)
@@ -629,3 +632,4 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
 	return dw_pcie_ep_init_complete(ep);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-03-19 12:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19 12:48 [PATCH] PCI: dwc: fix ERROR: modpost: dw_pcie_ep_*.o undefined Anders Roxell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).