From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Qiujun Huang <hqjagain@gmail.com>,
anders.roxell@linaro.org, vidyas@nvidia.com
Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
amurray@thegoodpenguin.co.uk, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] PCI: dwc: fix compile err for pcie-tagra194
Date: Thu, 19 Mar 2020 17:37:19 +0000 [thread overview]
Message-ID: <20200319173710.GA7433@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <1584621380-21152-1-git-send-email-hqjagain@gmail.com>
On Thu, Mar 19, 2020 at 08:36:20PM +0800, Qiujun Huang wrote:
> make allmodconfig
> ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make: *** [sub-make] Error 2
>
> need to export the symbols.
>
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 3 +++
> 1 file changed, 3 insertions(+)
I have squashed this in with the original patch.
@Vidya: is this something we missed in the review cycle ? Asking just
to make sure it was not me who made a mistake while merging the code.
Thanks,
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 4233c43..60d62ef 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)
>
> pci_epc_linkup(epc);
> }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_linkup);
>
> void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
> {
> @@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
>
> pci_epc_init_notify(epc);
> }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_notify);
>
> static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar,
> int flags)
> @@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_complete);
>
> int dw_pcie_ep_init(struct dw_pcie_ep *ep)
> {
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2020-03-19 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 12:36 [PATCH -next] PCI: dwc: fix compile err for pcie-tagra194 Qiujun Huang
2020-03-19 17:37 ` Lorenzo Pieralisi [this message]
2020-03-20 5:15 ` Vidya Sagar
2020-03-20 6:00 ` Qiujun Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319173710.GA7433@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=anders.roxell@linaro.org \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hqjagain@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).