From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3CA1C4332D for ; Thu, 19 Mar 2020 18:05:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95A7B207FC for ; Thu, 19 Mar 2020 18:05:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727383AbgCSSFe (ORCPT ); Thu, 19 Mar 2020 14:05:34 -0400 Received: from foss.arm.com ([217.140.110.172]:39812 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727108AbgCSSFd (ORCPT ); Thu, 19 Mar 2020 14:05:33 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 49B5730E; Thu, 19 Mar 2020 11:05:33 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 48A013F305; Thu, 19 Mar 2020 11:05:32 -0700 (PDT) Date: Thu, 19 Mar 2020 18:05:30 +0000 From: Lorenzo Pieralisi To: Thierry Reding Cc: Andrew Murray , Bjorn Helgaas , Jon Hunter , Vidya Sagar , linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] PCI: tegra: Print -EPROBE_DEFER error message at debug level Message-ID: <20200319180529.GB7433@e121166-lin.cambridge.arm.com> References: <20200319131230.3216305-1-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200319131230.3216305-1-thierry.reding@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Mar 19, 2020 at 02:12:30PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Probe deferral is an expected error condition that will usually be > recovered from. Print such error messages at debug level to make them > available for diagnostic purposes when building with debugging enabled > and hide them otherwise to not spam the kernel log with them. > > Signed-off-by: Thierry Reding > --- > drivers/pci/controller/dwc/pcie-tegra194.c | 42 ++++++++++++++++++---- > 1 file changed, 35 insertions(+), 7 deletions(-) Hi Thierry, what tree/branch is it based on ? I assume it may depend on some patches queued in one of my branches so please let me know and I will apply accordingly. Thanks, Lorenzo > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > index 97d3f3db1020..e4870fa6ce9c 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -1159,17 +1159,31 @@ static int tegra_pcie_dw_parse_dt(struct tegra_pcie_dw *pcie) > /* Endpoint mode specific DT entries */ > pcie->pex_rst_gpiod = devm_gpiod_get(pcie->dev, "reset", GPIOD_IN); > if (IS_ERR(pcie->pex_rst_gpiod)) { > - dev_err(pcie->dev, "Failed to get PERST GPIO: %ld\n", > - PTR_ERR(pcie->pex_rst_gpiod)); > - return PTR_ERR(pcie->pex_rst_gpiod); > + int err = PTR_ERR(pcie->pex_rst_gpiod); > + const char *level = KERN_ERR; > + > + if (err == -EPROBE_DEFER) > + level = KERN_DEBUG; > + > + dev_printk(level, pcie->dev, > + dev_fmt("Failed to get PERST GPIO: %d\n"), > + err); > + return err; > } > > pcie->pex_refclk_sel_gpiod = devm_gpiod_get(pcie->dev, > "nvidia,refclk-select", > GPIOD_OUT_HIGH); > if (IS_ERR(pcie->pex_refclk_sel_gpiod)) { > - dev_info(pcie->dev, "Failed to get REFCLK select GPIOs: %ld\n", > - PTR_ERR(pcie->pex_refclk_sel_gpiod)); > + int err = PTR_ERR(pcie->pex_refclk_sel_gpiod); > + const char *level = KERN_ERR; > + > + if (err == -EPROBE_DEFER) > + level = KERN_DEBUG; > + > + dev_printk(level, pcie->dev, > + dev_fmt("Failed to get REFCLK select GPIOs: %d\n"), > + err); > pcie->pex_refclk_sel_gpiod = NULL; > } > > @@ -2058,13 +2072,27 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) > > ret = tegra_pcie_dw_parse_dt(pcie); > if (ret < 0) { > - dev_err(dev, "Failed to parse device tree: %d\n", ret); > + const char *level = KERN_ERR; > + > + if (ret == -EPROBE_DEFER) > + level = KERN_DEBUG; > + > + dev_printk(level, dev, > + dev_fmt("Failed to parse device tree: %d\n"), > + ret); > return ret; > } > > ret = tegra_pcie_get_slot_regulators(pcie); > if (ret < 0) { > - dev_err(dev, "Failed to get slot regulators: %d\n", ret); > + const char *level = KERN_ERR; > + > + if (ret == -EPROBE_DEFER) > + level = KERN_DEBUG; > + > + dev_printk(level, dev, > + dev_fmt("Failed to get slot regulators: %d\n"), > + ret); > return ret; > } > > -- > 2.24.1 >