From: Christoph Hellwig <hch@infradead.org>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Randy Dunlap <rdunlap@infradead.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-pci@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Oleg Nesterov <oleg@redhat.com>,
Joel Fernandes <joel@joelfernandes.org>,
Will Deacon <will@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
"Paul E . McKenney" <paulmck@kernel.org>,
Logan Gunthorpe <logang@deltatee.com>,
Arnd Bergmann <arnd@arndb.de>,
linuxppc-dev@lists.ozlabs.org,
Steven Rostedt <rostedt@goodmis.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Kalle Valo <kvalo@codeaurora.org>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb <linux-usb@vger.kernel.org>,
linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [patch V2 11/15] completion: Use simple wait queues
Date: Thu, 19 Mar 2020 23:59:47 -0700 [thread overview]
Message-ID: <20200320065947.GA25206@infradead.org> (raw)
In-Reply-To: <CAGRGNgXAW14=8ntTiB_hJ_nLq7WC_oFR3N9BNjqVEZM=ze85tQ@mail.gmail.com>
On Fri, Mar 20, 2020 at 10:25:41AM +1100, Julian Calaby wrote:
> > +++ b/drivers/usb/gadget/function/f_fs.c
> > @@ -1703,7 +1703,7 @@ static void ffs_data_put(struct ffs_data
> > pr_info("%s(): freeing\n", __func__);
> > ffs_data_clear(ffs);
> > BUG_ON(waitqueue_active(&ffs->ev.waitq) ||
> > - waitqueue_active(&ffs->ep0req_completion.wait) ||
> > + swait_active(&ffs->ep0req_completion.wait) ||
>
> This looks like some code is reaching deep into the dirty dark corners
> of the completion implementation, should there be some wrapper around
> this to hide that?
Or just remote it entirely..
next prev parent reply other threads:[~2020-03-20 7:00 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 20:43 [patch V2 00/15] Lock ordering documentation and annotation for lockdep Thomas Gleixner
2020-03-18 20:43 ` [patch V2 01/15] PCI/switchtec: Fix init_completion race condition with poll_wait() Thomas Gleixner
2020-03-18 21:25 ` Bjorn Helgaas
2020-03-18 20:43 ` [patch V2 02/15] pci/switchtec: Replace completion wait queue usage for poll Thomas Gleixner
2020-03-18 21:26 ` Bjorn Helgaas
2020-03-18 22:11 ` Logan Gunthorpe
2020-03-18 20:43 ` [patch V2 03/15] usb: gadget: Use completion interface instead of open coding it Thomas Gleixner
2020-03-19 8:41 ` Greg Kroah-Hartman
2020-03-18 20:43 ` [patch V2 04/15] orinoco_usb: Use the regular completion interfaces Thomas Gleixner
2020-03-19 8:40 ` Greg Kroah-Hartman
2020-03-18 20:43 ` [patch V2 05/15] acpi: Remove header dependency Thomas Gleixner
2020-03-18 20:43 ` [patch V2 06/15] rcuwait: Add @state argument to rcuwait_wait_event() Thomas Gleixner
2020-03-20 5:36 ` Davidlohr Bueso
2020-03-20 8:45 ` Sebastian Andrzej Siewior
2020-03-20 8:58 ` Davidlohr Bueso
2020-03-20 9:48 ` [PATCH 0/5] Remove mm.h from arch/*/include/asm/uaccess.h Sebastian Andrzej Siewior
2020-03-20 9:48 ` [PATCH 1/5] nds32: Remove mm.h from asm/uaccess.h Sebastian Andrzej Siewior
2020-03-20 9:48 ` [PATCH 2/5] csky: " Sebastian Andrzej Siewior
2020-03-21 11:24 ` Guo Ren
2020-03-21 12:08 ` Thomas Gleixner
2020-03-21 14:11 ` Guo Ren
2020-03-20 9:48 ` [PATCH 3/5] hexagon: " Sebastian Andrzej Siewior
2020-03-20 9:48 ` [PATCH 4/5] ia64: " Sebastian Andrzej Siewior
2020-03-20 9:48 ` [PATCH 5/5] microblaze: " Sebastian Andrzej Siewior
2020-03-18 20:43 ` [patch V2 07/15] powerpc/ps3: Convert half completion to rcuwait Thomas Gleixner
2020-03-19 9:00 ` Sebastian Andrzej Siewior
2020-03-19 9:18 ` Peter Zijlstra
2020-03-19 9:21 ` Davidlohr Bueso
2020-03-19 10:04 ` Christoph Hellwig
2020-03-19 10:26 ` Sebastian Andrzej Siewior
2020-03-20 0:01 ` Geoff Levand
2020-03-20 0:45 ` Michael Ellerman
2020-03-21 10:41 ` Thomas Gleixner
2020-03-18 20:43 ` [patch V2 08/15] Documentation: Add lock ordering and nesting documentation Thomas Gleixner
2020-03-18 22:31 ` Paul E. McKenney
2020-03-19 18:02 ` Thomas Gleixner
2020-03-20 16:01 ` Paul E. McKenney
2020-03-20 19:51 ` Thomas Gleixner
2020-03-20 21:02 ` Paul E. McKenney
2020-03-20 22:36 ` Thomas Gleixner
2020-03-21 2:29 ` Paul E. McKenney
2020-03-21 10:26 ` Thomas Gleixner
2020-03-21 17:23 ` Paul E. McKenney
2020-03-19 8:51 ` Davidlohr Bueso
2020-03-19 15:04 ` Jonathan Corbet
2020-03-19 18:04 ` Thomas Gleixner
2020-03-21 21:21 ` Joel Fernandes
2020-03-21 21:49 ` Thomas Gleixner
2020-03-22 1:36 ` Joel Fernandes
2020-03-18 20:43 ` [patch V2 09/15] timekeeping: Split jiffies seqlock Thomas Gleixner
2020-03-18 20:43 ` [patch V2 10/15] sched/swait: Prepare usage in completions Thomas Gleixner
2020-03-18 20:43 ` [patch V2 11/15] completion: Use simple wait queues Thomas Gleixner
2020-03-18 22:28 ` Logan Gunthorpe
2020-03-19 0:33 ` Joel Fernandes
2020-03-19 0:44 ` Thomas Gleixner
2020-03-19 8:42 ` Greg Kroah-Hartman
2020-03-19 17:12 ` Linus Torvalds
2020-03-19 23:25 ` Julian Calaby
2020-03-20 6:59 ` Christoph Hellwig [this message]
2020-03-20 9:01 ` Davidlohr Bueso
2020-03-20 8:50 ` [patch V2 00/15] Lock ordering documentation and annotation for lockdep Davidlohr Bueso
2020-03-20 8:55 ` [PATCH 16/15] rcuwait: Get rid of stale name comment Davidlohr Bueso
2020-03-20 8:55 ` [PATCH 17/15] rcuwait: Inform rcuwait_wake_up() users if a wakeup was attempted Davidlohr Bueso
2020-03-20 9:13 ` Sebastian Andrzej Siewior
2020-03-20 10:44 ` Peter Zijlstra
2020-03-20 8:55 ` [PATCH 18/15] kvm: Replace vcpu->swait with rcuwait Davidlohr Bueso
2020-03-20 11:20 ` Paolo Bonzini
2020-03-20 12:54 ` Peter Zijlstra
2020-03-22 16:33 ` Davidlohr Bueso
2020-03-22 22:32 ` Peter Zijlstra
2020-03-20 8:55 ` [PATCH 19/15] sched/swait: Reword some of the main description Davidlohr Bueso
2020-03-20 9:19 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320065947.GA25206@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=bhelgaas@google.com \
--cc=bigeasy@linutronix.de \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=julian.calaby@gmail.com \
--cc=kurt.schwemmer@microsemi.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=logang@deltatee.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).