From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: Bjorn Helgaas <bhelgaas@google.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH] PCI/ASPM: Reduce severity of log message
Date: Mon, 23 Mar 2020 16:55:30 +1300 [thread overview]
Message-ID: <20200323035530.11569-1-chris.packham@alliedtelesis.co.nz> (raw)
When the UEFI/BIOS or bootloader has not initialised a PCIe device we
would get the following message.
kern.warning: pci 0000:00:01.0: ASPM: current common clock configuration is broken, reconfiguring
"warning" and "broken" are slightly misleading. On an embedded system it
is quite possible for the bootloader to avoid configuring PCIe devices
if they are not needed.
Downgrade the message to pci_info() and change "broken" to
"inconsistent" since we fix up the inconsistency in the code immediately
following the message (and emit an error if that fails).
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
I'm updating a system from an older kernel to the latest and our tests flagged
this error message. I don't believe it's actually an error since our bootloader
doesn't touch the PCI bus (infact the kernel releases the reset to that
particular device before the PCI bus scan).
drivers/pci/pcie/aspm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index 0dcd44308228..3a165ab3413b 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -273,7 +273,7 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link)
}
if (consistent)
return;
- pci_warn(parent, "ASPM: current common clock configuration is broken, reconfiguring\n");
+ pci_info(parent, "ASPM: current common clock configuration is inconsistent, reconfiguring\n");
}
/* Configure downstream component, all functions */
--
2.25.1
next reply other threads:[~2020-03-23 3:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 3:55 Chris Packham [this message]
2020-03-28 20:10 ` [PATCH] PCI/ASPM: Reduce severity of log message Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323035530.11569-1-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).