From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FEAC1975A for ; Wed, 25 Mar 2020 16:54:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE36A2073E for ; Wed, 25 Mar 2020 16:54:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727639AbgCYQyr convert rfc822-to-8bit (ORCPT ); Wed, 25 Mar 2020 12:54:47 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:48640 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727539AbgCYQyr (ORCPT ); Wed, 25 Mar 2020 12:54:47 -0400 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1jH9IM-00061w-Lf; Wed, 25 Mar 2020 17:54:22 +0100 Date: Wed, 25 Mar 2020 17:54:22 +0100 From: Sebastian Siewior To: "Paul E. McKenney" Cc: Thomas Gleixner , LKML , Peter Zijlstra , Ingo Molnar , Linus Torvalds , Joel Fernandes , Oleg Nesterov , Davidlohr Bueso , Jonathan Corbet , Randy Dunlap , Logan Gunthorpe , Bjorn Helgaas , Kurt Schwemmer , linux-pci@vger.kernel.org, Greg Kroah-Hartman , Felipe Balbi , linux-usb@vger.kernel.org, Kalle Valo , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, Zhang Rui , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org, kbuild test robot , Nick Hu , Greentime Hu , Vincent Chen , Guo Ren , linux-csky@vger.kernel.org, Brian Cain , linux-hexagon@vger.kernel.org, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, Michal Simek , Michael Ellerman , Arnd Bergmann , Geoff Levand , linuxppc-dev@lists.ozlabs.org, Davidlohr Bueso Subject: Re: Documentation/locking/locktypes: Further clarifications and wordsmithing Message-ID: <20200325165422.hfxzkxcj3jhqcstr@linutronix.de> References: <20200323025501.GE3199@paulmck-ThinkPad-P72> <87r1xhz6qp.fsf@nanos.tec.linutronix.de> <20200325002811.GO19865@paulmck-ThinkPad-P72> <87wo78y5yy.fsf@nanos.tec.linutronix.de> <20200325160212.oavrni7gmzudnczv@linutronix.de> <20200325163919.GU19865@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200325163919.GU19865@paulmck-ThinkPad-P72> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2020-03-25 09:39:19 [-0700], Paul E. McKenney wrote: > > > --- a/Documentation/locking/locktypes.rst > > > +++ b/Documentation/locking/locktypes.rst > > … > > > +rw_semaphore > > > +============ > > > + > > > +rw_semaphore is a multiple readers and single writer lock mechanism. > > > + > > > +On non-PREEMPT_RT kernels the implementation is fair, thus preventing > > > +writer starvation. > > > + > > > +rw_semaphore complies by default with the strict owner semantics, but there > > > +exist special-purpose interfaces that allow non-owner release for readers. > > > +These work independent of the kernel configuration. > > > > This reads funny, could be my English. "This works independent …" maybe? > > The "These" refers to "interfaces", which is plural, so "These" rather > than "This". But yes, it is a bit awkward, because you have to skip > back past "readers", "release", and "non-owner" to find the implied > subject of that last sentence. > > So how about this instead, making the implied subject explicit? > > rw_semaphore complies by default with the strict owner semantics, but there > exist special-purpose interfaces that allow non-owner release for readers. > These interfaces work independent of the kernel configuration. Yes, perfect. Thank you. > Thanx, Paul Sebastian