[PATCH] PCI/ASPM: Reduce severity of log message

[PATCH] PCI/ASPM: Reduce severity of log message

[Chris Packham]

When the UEFI/BIOS or bootloader has not initialised a PCIe device we
would get the following message.

  kern.warning: pci 0000:00:01.0: ASPM: current common clock configuration is broken, reconfiguring

"warning" and "broken" are slightly misleading. On an embedded system it
is quite possible for the bootloader to avoid configuring PCIe devices
if they are not needed.

Downgrade the message to pci_info() and change "broken" to
"inconsistent" since we fix up the inconsistency in the code immediately
following the message (and emit an error if that fails).

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
I'm updating a system from an older kernel to the latest and our tests flagged
this error message. I don't believe it's actually an error since our bootloader
doesn't touch the PCI bus (infact the kernel releases the reset to that
particular device before the PCI bus scan).

 drivers/pci/pcie/aspm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index 0dcd44308228..3a165ab3413b 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -273,7 +273,7 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link)
 		}
 		if (consistent)
 			return;
-		pci_warn(parent, "ASPM: current common clock configuration is broken, reconfiguring\n");
+		pci_info(parent, "ASPM: current common clock configuration is inconsistent, reconfiguring\n");
 	}
 
 	/* Configure downstream component, all functions */
-- 
2.25.1

Re: [PATCH] PCI/ASPM: Reduce severity of log message

[Bjorn Helgaas]

On Mon, Mar 23, 2020 at 04:55:30PM +1300, Chris Packham wrote:
> When the UEFI/BIOS or bootloader has not initialised a PCIe device we
> would get the following message.
> 
>   kern.warning: pci 0000:00:01.0: ASPM: current common clock configuration is broken, reconfiguring
> 
> "warning" and "broken" are slightly misleading. On an embedded system it
> is quite possible for the bootloader to avoid configuring PCIe devices
> if they are not needed.
> 
> Downgrade the message to pci_info() and change "broken" to
> "inconsistent" since we fix up the inconsistency in the code immediately
> following the message (and emit an error if that fails).
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Applied to pci/aspm for v5.7, thanks!

> ---
> I'm updating a system from an older kernel to the latest and our tests flagged
> this error message. I don't believe it's actually an error since our bootloader
> doesn't touch the PCI bus (infact the kernel releases the reset to that
> particular device before the PCI bus scan).
> 
>  drivers/pci/pcie/aspm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 0dcd44308228..3a165ab3413b 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -273,7 +273,7 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link)
>  		}
>  		if (consistent)
>  			return;
> -		pci_warn(parent, "ASPM: current common clock configuration is broken, reconfiguring\n");
> +		pci_info(parent, "ASPM: current common clock configuration is inconsistent, reconfiguring\n");
>  	}
>  
>  	/* Configure downstream component, all functions */
> -- 
> 2.25.1
>